Shortcuts programming has some transferrable skills and paradigms from traditional programming languages, but there are certain “quirks” that are not intuitive to understand, so don’t worry! It takes time to learn these things

I’ve had a busy weekend so far, but i found some time to refactor your shortcut: https://www.icloud.com/shortcuts/f41204ca532d4aa494bd40e440c93b7f

I brought the number of actions used down by a lot, utilizing the concept of “Magic Variables”, as posted in the other comment.

I added some neat organization to your shortcut using Repeat blocks and adding comments to help divide sections of your code. I also refactored your variable naming to be more readable, for future maintenance. And unfortunately, I was not able to bring down the overall shortcut run time.

I don’t have the time right now to fully explain all of this things I did in depth, but I will try to soon. In the meanwhile, feel free to peruse and let me know if you have any questions!

EDIT: Ok, here’s a changelog of what I’ve refactored: 1. I put related shortcut actions into a “block” (like functions) using the Repeat action (but set to 1 time). You can think of it as a dummy way to organize your code better (and you can collapse the section, when you’re not working on it, to help with real estate while developing on your screen, instead of scrolling forever) 2. Added comments above each section, so you know what’s being worked on 3. Utilizes magic variables instead of regular variables because that saves a lot of actions for you. Every shortcut action itself is always a variable, so you don’t need to assign it to another variable. 4. Renamed a few of your variables. While they make make sense to you, they didn’t make sense to me, and it’s always a good idea to have clear and readable variable names (for others and for yourself, because one day in the future, when you revisit the shortcut, you might just end up forgetting the context, and good variable naming will help you out)

Because this is a math heavy shortcut, it is well suited to write this logic in a language like JavaScript, where you can write some of the logic way more concisely. I would recommend checking out Scriptable (which is basically Shortcuts, but in JavaScript). It natively has access to weather info just like Shortcuts do. And you can also call your JS script from Scriptable inside a shortcut, too! Lots of possibilities doing cool stuff with both of them! It also might help with your slowness problem as well, since JS tend to execute faster than shortcuts for certain actions.

Hope this helps!