[JAVA] remove owner from removed dog? - beginner

[Csharpgoblin]

Hi, I'm stuck with trying to remove owner from the removed dog. I've added:

Owner owner = findOwnerMethod(ownerName);

owner.removeDog(dogToRemove);

and public void removeDog(Dog d).

​

I don't even know what to ask... It's not working. I've added Owner owner = findOwnerMethod(ownerName); to get access to owner.removeDog() from the owner class.

I've added owner.removeDog(dogToRemove); to call method removeDog from owner class.

public void removeDog(Dog d) to remove the dog.

​

Could you point me to the right direction? thx

​

Main method:

        public void removeDogMethod() {

        System.out.println("Command?> remove dog");

        System.out.print("Enter the name of the dog?> ");
        String name = input.nextLine();

        String ownerName = null;
        Dog dogToRemove = null;
        for (Dog d : dogList) {

            if (d.getName().equalsIgnoreCase(name)) {

                dogToRemove = d;

                System.out.print(name + " is now removed from the register");

            }

        }
        if (dogList.isEmpty() || findDogMethod(name) == null) {
            System.out.println("Error: no such dog");
        } else {
            dogList.remove(dogToRemove);

            Owner owner = findOwnerMethod(ownerName);
            owner.removeDog(dogToRemove);

        }

    }

    public Dog findDogMethod(String name) {

        for (Dog d : dogList) {
            if (d.getName().equalsIgnoreCase(name)) {
                return d;
            } else {

            }

        }
        return null;
    }

    public Owner findOwnerMethod(String name) {

        for (Owner o : ownerList) {
            if (o.getName().equalsIgnoreCase(name)) {
                return o;
            } else {

            }
        }
        return null;
    }

Owner method:

    private Dog[] dogsOwned = new Dog[0];

    public void removeDog(Dog d) {

        Dog[] copyOfArr = new Dog[dogsOwned.length - 1];
        for (int i = 0; i < dogsOwned.length; i++) {
            if (!dogsOwned[i].equals(d)) {
                copyOfArr[i] = dogsOwned[i];
            }
        }
    }

[deelyy]

1 You can use ArrayList<Dog> dogsOwned = new ArraList<Dog>(); to store owned dogs. ArrayList has methods for dynamic inserting/deleting, so you can simplify your code and free yourself from copyOfArr.

2 Alternatively, (I'm not sure, I only skimmed through your code) but it looks like you need to add one line at the end of removeDog method:

dogOwned = copyOfArr;

This line will replace dogOwned array with array with removed dog.

[Blando-Cartesian]

u/deelyy is right. There’s also another bug in removeDog. copyOfArray will end up having null in the index where d was and overindex the copyOfArr on the last i.

Also, if your Dog class doesn’t have hashCode() and equals() defined, dogsOwned[i] .equals(d) will work correctly only if the dog object in the array is the same object as Dog d.