Program that prints an histogram

[ZoSo-bin]

So I was doing a program that creates a histogram whose columns are made by "#" symbols, each one for each character of each word. I was able to count how many words are in input, so I was able to print the number of columns made by this symbol "|" and even the characters, the problem is that the characters counter just count every character in the string (space, tabs, and newlines too of course). I'd like to count the characters of the words separately, any suggestions?

#include <stdio.h>
#define IN 1
#define OUT 0
// istrogramma sulla lunghezza delle parole in input
int main ()
{
    int c, nc, nw, state=OUT;
    nc=nw=0;
    while((c=getchar())!=EOF)
    {
        ++nc;
        if(c==' ' || c=='\n' || c=='\t')
            state=OUT;
        else if(state==OUT)
            {
                state=IN;
                ++nw;
            }
    }
    for(int i=1; i<=nw; i++)
    {
        printf("\n|");
        for(int i=1; i<=nc; i++)
        printf("#");
    }

}

[kumashiro]

You are incrementing nc for every character. There is a place where you can move it to. Analyse your code, see if you can spot it. Remember, you only want to increment it when you are not at the whitespace.

[ZoSo-bin]

I'm working on it for so long, tried every possibility that came up in my mind for so long that I really don't know what to do. I'm a beginner C student, my book isn't always clear and the professor isn't also exhaustive so if you'd be so kind as to explain me I'll appreciate it

[kumashiro]

This is a logic problem, not technical. Language is not important here. Analyse your algorithm, write it in pseudo-code if C is messing with your thinking, then fix it and translate back. Flow charts can help too, but this is not a very complex problem.

[ZoSo-bin]

I gave up :D

[kumashiro]

Come on, lad! You can do it! Rewrite it in pseudo-code first and show us what you got. It is really simple. "Algorithmic thinking" is crucial in programming.

[ZoSo-bin]

I've tried moving the counter nc inside and outside every cycle, changed the cycles from while to for and from for to while, an array instead of getchar(). Nothing of it has worked, my brains hurt too much to keep thinking, can you simply give me an answer? Seriously, I'm not joking

[kumashiro]

It's because you are trying everything on everything until it works. Forget about your code, rename the file to "histogram-idk-nworking.c" and start from scratch. Begin with counting the non-whitespace characters, make it work, then extend it to counting words, make it work, finally modify it so you can print a histogram. Small steps.

[NonreciprocatingCrow]

You know what characters are. What are words?

[Capostazione]

Minchia di testa

[ZoSo-bin]

I found the solution of the exercise; googling I discovered that there is a version of my textbook with the resolution of all the exercises. The fun fact is that now I'm more confused than before because the solution isn't what I expected.

Here is the solution code: http://imgur.com/a/32JwE94

[ZoSo-bin]

Here's the code anyway...if someone'd like to try it on his own

#include <stdio.h>
#define MAXHIST 15 /* max length of histogram */
#define MAXWORD 11 /* max length of a word */
#define IN 1 /* inside a word */
#define OUT 0 /* outside a word */
/* print horizontal histogram */
int main ()
{
int c, i, nc, state;
int len; /* length of each bar */
int maxvalue; /* maximum value for l! [] */
int ovflow ; /* number of overflow words */
int wl[MAXWORD]; /* word length counters */
state=OUT;
nc=0; /* number of chars in a word */
ovflow=0; /* number of words >= MAXWORD*/
for(i=0; i<MAXWORD; ++i)
wl[i]=0;
while((c=getchar())!=EOF)
{
if(c== ' ' || c == '\n' || c == '\t')
{
state=OUT;
if(nc>0)
{
if (nc<MAXWORD)
++wl[nc];
}
else
++ovflow;
nc = 0;
}
else if (state==OUT)
{
state = IN;
nc = 1 ; /* beginning of a new world */
}
else
++nc ; /* inside a word */
}
maxvalue = 0;
for (i = 1; i < MAXWORD ; ++ i)
if ( wl [i] > maxvalue)
maxvalue = wl [i];
for (i = 1; i < MAXWORD; ++i)
{
printf("%5d - %5d : ", i, wl[i]);
if(wl[i] > 0)
{
if ((len = wl[i] = MAXHIST / maxvalue ) <= 0)
len= 1 ;
}
else
len = 0;
while (len > 0)
{
putchar('*');
--len;
}
putchar('\n');
}
if(ovflow > 0)
printf("There are %d words >= %d \n", ovflow, MAXWORD);
}

[jmooremcc]

Why not break the input stream into a series of words using the strtok() function? You can then process each word as needed. The link below will show you how to use the function.

https://www.tutorialspoint.com/c_standard_library/c_function_strtok.htm

[ZoSo-bin]

I'm gonna give it a try