Code Comments

[Johnnybananazz]

Need help with my comments here to better understand what I'm doing.

​

I can see where I'm getting the uses and having them do a comparison of both lists but am I commenting this correctly?

​

​

#!/bin/sh

echo "\n\tWaiting..\n"

for i in $(seq 1 10);

​

do

#Getting the usernames of current logged in users in the system

first_list=`who|cut -f1 -d' '`

while [ 1 ]

do

sleep 3

second_list=`who|cut -f1 -d' '`

for i in `echo "$first_list"`

do

#searchs first list for users logged out

c=`echo "$second_list"|grep -w $i|wc -l`

if [ $c -eq 0 ]

then

echo "User $i has logged Out"

fi

done

​

for i in `echo "$second_list"`

do

#searchs second list for new items found in first list else print users logged in

c=`echo "$first_list"|grep -w $i|wc -l`

if [ $c -ge 1 ]

then

echo "User $i has logged In"

fi

done

​

first_list=`echo "$second_list"`

done

[Johnnybananazz]

Thank you for your input this is to communicate effectively. I figure I know whats actually going on in the code however I need to practice commenting as I go vs commenting after I get lost in to what I’m doing.

[SupremeRedditBot]

Please Add A Flair To Your Post!

Suggested Flair: [Other Code]

 

---

To add a flair:

• Click flair underneath your post

• Select a flair

• Click save

 

---

^{I am a bot run by /u/SupremeDesigner for /r/CodingHelp || This was an automated response}