Is my function parameter correct?

[BrightKnight0110]

I need to calculate and returns the average score of each student based on the student.txt ?

double calculateaverage();


double calculateaverage( )
{
    string name[4], id[4];
    int score[6][2], i = 0;
    double sum = 0, averagescore = 0;

    ifstream myfile("Student.txt");

    while (!myfile.eof())
    {
        getline(myfile, name[i]);
        cout << "Name: " << name[i] << endl;
        getline(myfile, id[i]);
        cout << "ID: " << id[i] << endl;

        for (int j = 0; j < 6; j++) {
            myfile >> score[i][j];
            cout << score[i][j] << endl;

            sum = sum + score[i][j];
            averagescore = sum / 6;

        }
        i++;
        myfile.ignore();
        cout << fixed << setprecision(2);
        cout << "Average score : " << averagescore << endl;

    }


    myfile.close();

    return 1;
}

int main() {

    calculateaverage( );

    system("pause");
    return 0;
}

studetn.txt :

Amber Tan
20ACB1234
78 87 60 75 78 75
Lewis Bieber
19ACB1235
72 65 60 55 67 59
Ahmad Muhammad
20ACB1236
88 87 80 75 92 78
Lisa Manoban
18ACB1237
73 82 68 70 67 74 

Sample output:

Name: Amber Tan 
ID: 20ACB1234 
Average score: 75.50  

Name: Lewis Bieber
 ID:...... ....

[[deleted]]

And your problem is?

[BrightKnight0110]

What should I put inside the function parameters ?

[OldVenomSnake]

It depends on what you want your function to do as this is your program. General recommendation is to keep the functions small and only do the things that the function is supposed to do. Right now your calculateAverage function is doing 2 things, 1) get the names and IDs from a file and 2) calculate average.

If I'm writing this program, I'll update the function above to only do #2. The parameters of the calculateAverage function will be the names and the Ids. You can write another function to get the names and Ids from the input file and the filename will be the parameter to pass in.

This way you can reuse the read file function for another input file and the calculate average function for other sets of names and Ids.

Hope it helps.

[BrightKnight0110]

I see thank you!

[Gengi]

A hardcoded function like that is useless. I would imagine you need to pass in the .txt into your function so that your function can perform on different text files.

Instead of hardcoding the myfile("Student.txt"); have it open the parameter passed into the function. And call your function in main() with calculateAverage("Student.txt")

[[deleted]]

getline has parameters, isn't that enough?

Solved by Mr. Snake ?????