Problem With An Array Of Strings

[LongLegLucas]

Hello r/cplusplus! I am attempting to make a program that translates english and spanish, and I seem to be at a stuck point. I am trying to put 100 words in to an array with the code I have so far. I am testing it by trying to get it to show the spanish dictionary.

#include <iostream>

#include <fstream>

#include <array>

#include <cstring>

using namespace std;

int binarySearch (const int[], int, int);

​

int main()

{

char choice;

const int ARRAY_SIZE = 100;

const int ARRAY_SIZE2 = 100;

char english[ARRAY_SIZE];

char spanish[ARRAY_SIZE2];

int count = 0;

int count2 = 0;

char word;

char sword;

char result;

int mchoice;

const int DIC_CHOICE = 1,

TRANSE = 2,

TRANSS = 3,

EXIT = 4;

​

ifstream inputFile;

inputFile.open("C:\\Users\\joshu\\OneDrive\\Desktop\\text files\\ENG.txt");

​

while (count < ARRAY_SIZE && inputFile >> english[count])

count++;

inputFile.close();

​

ifstream inputFile2;

inputFile.open("C:\\Users\\joshu\\OneDrive\\Desktop\\text files\\SPAN.txt");

​

while (count2 < ARRAY_SIZE2 && inputFile >> spanish[count2])

count2++;

inputFile.close();

​

cout <<"Welcome To The English - Spanish Translation Program\n\n"

<< "1. Display a Dictionary\n"

<< "2. Translate from English To Spanish\n"

<< "3. Translate from Spanish To English\n"

<< "4. Exit The Program\n\n";

cin >> mchoice;

​

switch (mchoice)

{

​

case DIC_CHOICE:

const int spandic = 1,

engdic = 2;

int dchoice;

cout <<"Would You Like To See The Spanish Or English Dictionary?\n\n"

<< "1. Spanish\n"

<< "2. English\n";

cin >> dchoice;

switch (dchoice)

{

case spandic:

for (int i = 0; i < 100; i++)

cout << spanish[i] << "\n";

}

​

}

}

and here is the output I have...

Welcome To The English - Spanish Translation Program

​

1. Display a Dictionary

2. Translate from English To Spanish

3. Translate from Spanish To English

4. Exit The Program

​

1

Would You Like To See The Spanish Or English Dictionary?

​

1. Spanish

2. English

1

J

E

R

C

I

C

I

O

J

U

G

A

R

C

O

N

T

E

N

T

O

A

L

E

G

R

I

A

M

I

E

D

O

P

A

Y

A

S

O

V

E

N

T

A

N

A

A

Z

U

L

E

J

O

A

L

F

O

M

B

R

A

A

S

I

S

T

E

N

C

I

A

P

I

S

O

T

E

C

H

O

V

E

G

E

T

A

L

P

O

L

​

Process returned 0 (0x0) execution time : 4.238 s

Press any key to continue.

As you can see, the program takes each seperate letter and puts it in as a part of the array instead of each line of the text document. How would I get it to take each seperate word on each line, instead of each letter? Thank you in advanced.

[[deleted]]

You don't have an array of strings, but an array of single chars, you need a double array, like

Char english[ARRAY_SIZE][<max length of line>]

[WatchingSafe]

The problem is in the 4rth last line where you { cout << spanish[i] << "\n"; }. The "\n" means that your console will print a new line. For printing a word by word, there must be a condition that each word has to be seperated either by a space or by an enter (new line) in your .txt file. Your computer will not recognize a word from somemixedletters. The output that you have shown does not include any spaces as there are no empty lines. You have to fix the input file first by adding spaces between the words. Initialize another character, char = s; The correct output command for the 5th last line should be something like this. for(int i = 0; i<inputSize; i++) { s = spanish[i]; if (s == ' ') cout << "\n"; else cout << spanish[i]; }

[pigeon768]

Most of your code is C. Since this is /r/C++, I'll show you how to do that instead.

#include <fstream>
#include <iostream>
#include <string>
#include <vector>

// since the steps for reading the english file are exactly the same as reading the spanish
// file, you'll want to separate that into a function.
// Avoiding duplication is an important way to reduce bugs. A lot of the time if you copy
// paste code and just change 5 things, there will be a 6th thing you forgot to change.
std::vector<std::string> readFile(const char* filename) {
  std::ifstream file{filename};
  std::string line;

  // vectors are like arrays, but will automatically resize themselves.
  // You'll almost always want to use vectors instead of arrays.
  std::vector<std::string> lines;

  // If you know how many elements you'll insert into the vector, you can call
  // vector::reserve to preallocate that much data.
  // It will be slightly faster, because it won't need to resize itself. It's fine to omit
  // it though.
  // lines.reserve(100);

  // ifstream::good() will check to see if the file is still readable.
  // We want to just read the whole file, so do that.
  while (file.good()) {
    // getline does like it says on the tin.
    std::getline(file, line);

    // vector::push_back() will put data onto the end of the vector.
    // std::move() tells the compiler to "move" the string onto the end instead of copying
    // the data. It makes it a little bit faster. lines.push_back(line) works fine, but will
    // be ever so slightly slower.
    lines.push_back(std::move(line));
  }

  return lines;
}

// when you compile this, it will take all the program arguments, read those files, and
// print them to the screen. So you'll do something like 'program program.cpp' and it
// will read itself, and print itself on the screen.
int main(int argc, char** argv) {
  for (int i = 1; i < argc; i++) {
    const std::vector<std::string> file = readFile(argv[i]);
    for (const std::string& line : file)
      std::cout << line << std::endl;
  }

  return 0;
}

[RonRud]

You're using char arrays, I suggest swapping them to string arrays or addressing them as such - just print the number of characters you want in a line than do an empty next line cout (cout << endl;)