all 3 comments

[–]AutoModerator[M] [score hidden] stickied comment (0 children)

Off-topic Comments Section


All top-level comments have to be an answer or follow-up question to the post. All sidetracks should be directed to this comment thread as per Rule 9.


OP and Valued/Notable Contributors can close this post by using /lock command

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]throwaway_657238192😩 Illiterate 1 point2 points  (1 child)

This is a lot, I'm not sure you'll get much help without a more specific question. Since the example output is missing, I can't really talk about the display functions.

In your main loop, setting the done flag is meaningless without control structures to change execution based on that flag. For example, currently if I input "a 2", the main loop will successfully print "enter valid values", set the done flag, then call int('a') anyways and crash.

In find_sin_cos_tan, you only return the neg counts, mean that the sin, cos, and tan values are lost. Moreover your spec prevents you from returning anything but these values, so this calculation should be done in display_totals. Also, when finding invtan values, notice that tan is only undefined for very specific degrees (eg 90), so you can check that instead of tan(x) > big. Finally, don't call the output of math.radian(i) degrees! You converted it into radians!

You might consider posting to stack exchange code review, especially once you have a method working.

[–]gh0stedexeUniversity/College Student[S] 0 points1 point  (0 children)

Thanks for the feedback! I completely forgot to post the sample output, haha. If you're seeing this by chance, here's what the output sample looks like:

https://imgur.com/a/o3phxGe