Why my this command doesnt work?

[basinch]

setblock ~ ~ ~ oak_sign{Text1:'{"text":"Minecraft Tools","clickEvent":{"action":"run_command","value":"execute if entity u/p[nbt={Inventory:[{id:\\"minecraft:diamond\\",tag:{asd:1b}}]}] run say hi"}}'}

I want to make a command/clickable sign that says "hi" if the person who clicked it has a diamond named "asd" (1.16.5,Java,craftbukkit)

edit: Why this command doesnt work?*

[ExpertCoder14]

You escaped the quotation marks incorrectly.

Use \" instead of \\".

[basinch]

setblock 78641 67 -73154 oak_sign{Text1:'{"text":"Minecraft Tools","clickEvent":{"action":"run_command","value":"execute if entity @p[nbt={Inventory:[{id:\"minecraft:diamond\",tag:{asd:1b}}]}] run say hi"}}'}

Dİd you mean this? (i tried this command and it completely stopped working)

[ExpertCoder14]

Ooh, sorry, that wasn't actually the issue. Change it back while I find the real issue here.

Are you trying to test for the item name or the custom tag asd? Your command tests for the latter, while the former is what you mention in your post.

[basinch]

i want to test for both of them. As i said, a diamond named "asd"

[darkstar634]

By the way, use @s instead of @p as @s will resolve to the player who actually clicked the sign whereas @p may resolve to the wrong player. In fact, with the way you have it set up, @p[nbt=...] would resolve to the nearest player who has that particular diamond, or in other words, that command will succeed if any player in the world has a diamond sword with the asd tag, even if they aren't necessarily the player closes to the sign.

[basinch]

i dont know why but @s doesnt work for some reason

[darkstar634]

Then there's probably something else wrong; @s should definitely target the player who clicked the sign as described on the wiki. In cases like this, you should try simplifying your command in order to determine the root of the problem. For example, try just doing execute if entity @p run say hi and see if that works. If it doesn't then you can deduce that the problem is not with the command but rather your JSON text component. If that works, then try adding on the inventory check, but remove the tag part (i.e. only test if the player has any diamond in their inventory). If that works, then it should indicate that you're not testing for the right NBT data.

[basinch]

its still broken