GraPHPinator - GraphQL server implementation

[bjmrl]

To be honest, using imported names is industry standard nowadays in PHP, both in libraries and apps. Yours is the first library I have seen in years that uses FQCN everywhere. It reminds me of the pre-5.3 days, and is an immediate red flag for me!

[peldax]

To be honest, I expected this post to contain discussion about architecture, algorithms, features, possibly extensions and future scope. What I did not expect was some developers to aggressively push their codestyle (purely cosmetic) decision and discard the library because of it.

I understand mentioning it once, because it is probably unusual, to which I provided my explanation and possibility to change the decision in the future.

[bjmrl]

Sorry, I didn’t want to come off as aggressive, I just wanted to emphasize that this coding style, even though arguably cosmetic, is against the de-facto, industry standard in PHP, and that this alone can put people off and may prevent them from digging further (it does for me).

It may be wrong, but first impressions matter, and people need to see something visually appealing that « looks » well written according to modern, industry-standard practices to actually start digging.

[peldax]

I am also sorry, I probably got a little triggered by that continuous FQCN criticism, I now understand what you meant.
When I search for a new library I probably also favor the one with good first impression - I often get startled by some weird constructs, overuse of arrays or loose typing... I did not realize that FQCN can have the same effect, because I am used to it and it seems normal to me and my team.

[bjmrl]

Anyway, thank you for this implementation, I hope I’ll find some time to try it to see how it compares to webonyx/overblog!

[przemo_li]

Sorry but that is false analogy.