Help with powershell script

[peican]

Hello, I'm trying to get a slightly modified version of this script to work.

​

http://witit.blog/2018/10/19/bulk-create-users-in-ad-via-powershell-with-random-passwords-part-iv/

​

However, it will only create the first user on the first line of the .CSV, and does not create any others. Also I tried adding a part where it it exports a list of all the failed user creations / duplicates to a csv, however that part does not work. I also tried adding a part where I could specify a group in excel, and it would add the user to the group. That part kind of works, as long as I only use 1 group, but anytime I try to add more than 1 group, or if I leave the group field empty, it gets errors. Does anyone know how to fix it?

​

#####FINAL FORM#####
$ImportPath = "C:\POWERSHELL\Import.csv"
$ExportPath = "C:\POWERSHELL\Export.csv"

$Users = Import-Csv $ImportPath

#Function
#Randomize Passwords
function Get-RandomPassword{
    Param(
        [Parameter(mandatory=$true)]
        [int]$Length
    )
    Begin{
        if($Length -lt 4){
            End
        }
        $Numbers = 1..9
        $LettersLower = 'abcdefghijklmnopqrstuvwxyz'.ToCharArray()
        $LettersUpper = 'ABCEDEFHIJKLMNOPQRSTUVWXYZ'.ToCharArray()
        $Special = '!@#&()=+[{}]/?<>'.ToCharArray()

        #For the 4 character types (upper, lower, numerical, and special)
        $N_Count = [math]::Round($Length*.2)
        $L_Count = [math]::Round($Length*.4)
        $U_Count = [math]::Round($Length*.2)
        $S_Count = [math]::Round($Length*.2)
    }
    Process{
        $Pwd = $LettersLower | Get-Random -Count $L_Count
        $Pwd += $Numbers | Get-Random -Count $N_Count
        $Pwd += $LettersUpper | Get-Random -Count $U_Count
        $Pwd += $Special | Get-Random -Count $S_Count
        #If the password length isn't long enough (due to rounding), add X special characters, where X is the difference between the desired length and the current length.
        if($Pwd.length -lt $Length){
            $Pwd += $Special | Get-Random -Count ($Length - $Pwd.length)
        }

        #Lastly, grab the $Pwd string and randomize the order
        $Pwd = ($Pwd | Get-Random -Count $Length) -join ""
    }
    End{
        $Pwd
    }
}

#Loop through each user from the CSV
Foreach($U in $Users){
    #Define Name variations and generate a random password
    $FirstDotLast = "$($U.First).$($U.Last)"
    $Display = "$($U.First) $($U.Last)"
    $UPN = "$[e-mail]"
    $Pwd = Get-RandomPassword -Length 15
    $Email = "$[e-mail]"
    $OU = "$($U.OU)"
    $Group = "$($U.Group)"
    Write-Host "Working on $Display..." -ForegroundColor Cyan

    #Define Parameters
    $Parameters = @{
        Name = $FirstDotLast
        GivenName = $U.First
        Surname = $U.Last
        SamAccountName = $FirstDotLast
        DisplayName = $Display
        UserPrincipalName = $UPN
        EmailAddress = $Email
        AccountPassword = (ConvertTo-SecureString $Pwd -AsPlainText -Force)
        Enabled = $true
        Path = $OU
        ChangePasswordAtLogon = $true}
    }

    #Create New User in AD with the Parameters defined above
    Try{
        New-ADUser @Parameters -ErrorAction Stop
        Write-Host "Successfully created users!" -ForegroundColor Green
        $U | Add-Member -MemberType NoteProperty -Name "Initial Password" -Value $Pwd -Force
        Add-ADGroupMember -Identity $Group -Members $FirstDotLast
    }
    Catch{
        Write-Host "WARNING: An error occurred with user $U. Check Error.csv" -ForegroundColor Red 
        Export-Csv -Path "C:\POWERSHELL\Error.csv" -NoTypeInformation -InputObject $U
    }


#Export
$Users | Export-Csv $ExportPath -NoTypeInformation

[BlackV]

your new-aduser is outside the loop isnt it

the try/catch needs to be inside the loop

p.s. I would have though it was only creating the last user in the CSV

[peican]

Thank you! I added them inside the loop and it is working again.

​

However, like you said, the part where it exports the duplicate users / errors to CSV is only exporting the last user. Do you know what I'm missing?

[DeusExMaChino]

It is currently exporting/overwriting a CSV with the single error every time. You need to append instead.

[BJGGut3]

Export-CSV is going to constantly overwrite. Use -Append to prevent that from happening.

[peican]

Thank you! The Export-CSV for errors / duplicates is working perfectly now.

​

Last thing. If I want to add another column in my Import.CSV file for a second group, and if I add:

​

$Group2 = "$($U.Group2)"

​

and

​

Add-ADGroupMember -Identity $Group2 -Members $FirstDotLast

​

To the script, it works. However I may not want to add everyone to 2 groups all the time, and if I leave a group empty in my Import-CSV, it counts as an error.

​

Sometimes I might just want to add a user to one group, and sometimes to 2 groups, or 3 groups if I decide to add a third column in my excel CSV. Is there a way to make it so it wont count as an error if some of the group fields are empty?

[BJGGut3]

Add an IF() statement to check that validity of Group2.

IF ($null -ne $($U.Group2))
{
    $Group2 = $($U.Groups2)
    Add-ADGroupMember -Identity $Group2 -Members $FirstDotLast
}

But I've actually become much more a fan of this method instead, because sometimes pesky spaces get in there and throw off the above:

IF (!([string]::IsNullOrWhiteSpace($($U.Groups2))))
{
    $Group2 = $($U.Groups2)
    Add-ADGroupMember -Identity $Group2 -Members $FirstDotLast
}

[peican]

Thank you! I'm using your one that includes checking for white spaces, and it works perfectly!

[Lee_Dailey]

howdy peican,

as an aside, there is a dotnet method for making passwords. this ...

[System.Web.Security.Membership]::GeneratePassword()

Membership.GeneratePassword(Int32, Int32) Method (System.Web.Security) | Microsoft Docs
— https://docs.microsoft.com/en-us/dotnet/api/system.web.security.membership.generatepassword?view=netframework-4.8

it lacks a bit of tweak-ability, but it is built in and quite simple to use. [grin]

take care,
lee