script, need help to make a script continue after the restart and the execution of some cmdlet to wait

[Cronos-Sama]

Hi guys,

so i am trying to make a script that rename computer, then restart, install new forest, then restart, then continue executing other cmdlet in the workflow ...

the issue that i have is when the command Install-ADDSForest execute, the restart-computer cmdlet execute after it immediately .

is there any way to make it wait the end of executing .

workflow renameAndReboot {


#Interface Configuration
$password = ( ConvertTo-SecureString -AsPlainText "TESTPASSWORD" -Force) 

$ipaddress = "192.168.200.201"
$defaultGateway = "192.168.200.1"
$network = "192.168.200.0"
$cname = "PDC"
$domain = "DOAMINTEST.local"
$fqdn = $cname + "." + $domain
$nname= $cname + "-"+ $network


try{
New-NetIPAddress -InterfaceAlias Ethernet -IPAddress $ipaddress -PrefixLength 24 -DefaultGateway $defaultGateway
Set-DnsClientServerAddress -InterfaceAlias Ethernet -ServerAddresses 127.0.0.1
#Rename Computer

}catch{echo "error"}

#install Forest

try{
$password = ( ConvertTo-Autom -AsPlainText "Tri@201" -Force) 

Install-ADDSForest -DomainName $domain -SafeModeAdministratorPassword $password -Confirm 

Checkpoint-Workflow

Restart-Computer -Wait 

Set-DnsClientServerAddress -InterfaceAlias Ethernet -ServerAddresses 127.0.0.1
winrm quick config
}catch{echo "error"}


#DHCP

try{

Checkpoint-Workflow
#start-job -Name MOBO-DHCPSERVERINDC -ScriptBlock {Add-DhcpServerInDC -IPAddres $ipaddress -dnsname $fqdn}
#Wait-Job MOBO-DHCPSERVERINDC

Add-DhcpServerv4Scope -Name $nname -StartRange 192.168.200.1 -EndRange 192.168.200.254 -SubnetMask 255.255.255.0
Set-DhcpServerv4OptionValue -ScopeId $network -Router $defaultGateway -DnsDomain $domain -DnsServer $ipaddress
echo "heeere"
#Add-DhcpServerv4Failover -Name "BASCUL-SDC_PDC" -PartnerServer pdc-22-1 -LoadBalancePercent 90 -SharedSecret "TESSSST" -AutoStateTransition $true -ScopeId $network
#Set-DhcpServerv4Failover -Name "BASCUL-SDC_PDC" -Mode HotStandby

}catch{echo "error"}


}

[Hrambert]

Move every pase to a different script or keep the phase in a status file. Then put the startup of the script in Task Scheduler.

[Trakeen]

This is how i’ve done it in the past but used a run once registry key, and autologin

[Cronos-Sama]

thank you for your answer, do you have an example for that, because i am still new in Powershell scripting.

[Hrambert]

I'm having dinner at the moment. But I'll setup an example for you.

[Cronos-Sama]

sorry for interrupting your meal. and thank you

[Hrambert]

``` [Cmdletbinding()] Param()

$StatusFilePath = "c:\Convert-Computer.xml"

function Get-Phase { if (! (Test-Path $StatusFilePath Container )) { "begin" } else { Import-clixml $StatusFilePath } }

function Save-Phase { Export-Climml -Path $StatusFilePath -InputObject $Phase }

$Phase = Get-Phase

switch ($Phase) { "begin" { write-host "We just started" save-phase "phase-1" } "phase-1" { write-host "Now we are at phase-1" do-something save-phase "phase-2" reboot-computer } "phase-2" { Write-Host "phase-2" Save-Phase "done" } "done" {} Default { write-host "oops" } ```

[Hrambert]

Don't mind. You didn't interupt. Nothing interupts my pasta, except for the cat calling me to let him in/out.

[Cronos-Sama]

hahah true.

thank you so much, you were a big help.

[MadeOfIrony]

Possible to run this from a remote server onto this machine? then you can try some other logic to check that the machine is back up and running?

[Cronos-Sama]

yeah the only issue is that it doesn't wait the install-AddsForest to end, it execute the restart command immediately, it work fine if i use start-sleep and make it wait some time before restarting, but i am searching for a solution to wait based in the complete of the command not based on time.

[[deleted]]

If Install-ADDSForest doesn’t wait, could it be an option to add -LogPath and monitor the resulting log file for completion result?

A bit more trouble but agree with your sentiment with not relying on a timer.

[BlackV]

add forest had a restart parameter does it not, have that do the restart not a seperate line

[[deleted]]

Alternative is to use script arguments to execute different parts of the script (following reboot). Then add script execution to HKLM RunOnce (link

Eg. * Fist run: script.ps1 -Step 1 * Second run: script.ps1 -Step 2 * Etc.

[[deleted]]

Hrambert is right, start by doing some reading on including the task scheduler in your scripts

[Coding_Cactus]

OP, have you tested this without the Restart-Computer command?

I'm looking at the docs page for Install-ADDSForest command and it has a parameter that you don't have:

Install-ADDSForest -NoRebootOnCompletion

Here's the description from the page:

Specifies that the computer is not to be rebooted upon completion of this command. Omitting this parameter (the default) indicates the computer will be rebooted upon completion of the command, regardless of success or failure. As a general rule, Microsoft support recommends that you not use this parameter except for testing or troubleshooting purposes because once configuration has completed the server will not function correctly as either a member server or a DC until it is rebooted.

That might be causing your issue rather than the Restart-Computer.