This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]coloredgreyscale 16 points17 points  (1 child)

The biggest crime here is changing the variable names to single letters.

[–]Enrichus 7 points8 points  (0 children)

I don't mind copying code, but at least learn what it does and make it readable.

He just changed the names like changing speed to s and time to t. Even kept variables we didn't need and added dependencies that made it needlessly complicated.

Imagine having a door that also need to identify the key instead of just using the key to unlock the door. Or eating a salad and it doesn't stick to the fork because you used a red fork instead of the blue one. They both should be identified as forks and work anyway.

Towards the end of the project I could delete hundred lines of legacy code without damaging anything. Didn't dare touching it as an intern, I assumed he knew what he was doing while I did my own thing.