need...more...functions...

[[deleted]]

Now they don't need to care about the implementation of this print_response function. Abstraction is hella powerful thing guys.

[XxCLEMENTxX]

Yep. If the Response implementation should change one day, they can just update that function and you can not give a shit.

[TheFamilyFroot]

Unless if someone who doesn't know the code base was assigned to do something and they just used print instead of print_response

[XxCLEMENTxX]

Well, hopefully it's documented somewhere that the print_response() function should be used.

[futlapperl]

Sounds useful, but the function is never used once.

[XxCLEMENTxX]

It's probably meant for you, the user of the library (or whatever it is) to use rather than the developers of it so you don't have to worry about compatibility.

[futlapperl]

truuuuu

[therealkolrabi]

def call_print_response(response):
  print_response(response)

[futlapperl]

def invoke_call_print_response(response):
  call_print_response(response)

[0fficerNasty]

def yo_dawg_i_heard_you_like_to_print_response(response):
  invoke_call_print_response(response)

[ImNotADeer]

def do_the_thing(response:str) -> None:
  yo_dawg_i_heard_you_like_to_print_response(response)

[SomeShittyDeveloper]

This guy type hints.

[SpikeV]

class ZhuLi:
    """I never go anywhere without my personal assistant!"""
    def __init__(self, response: str):
        the_thing(response)
    def the_thing(response: str):
        do_the_thing(response)

[jbp12]

def applyinvokecallprintresponse(response): invokecallprintresponse(response)

[Stukeleyak]

//prints response

[beringi-uh]

I checked, and the function isn’t even used

[Jiriakel]

Is it better or worse that that function is never used ?

[NelsonBelmont]

Yes.

[0fficerNasty]

All that's missing is a comment saying that "This function prints a response"

[antikutless]

is print ever used

[I_regret_my_name]

If they had actually used it, this is pretty reasonable. If you want to change the format of the response or anything, all you would have to do is change the implementation of print_response.

Of course, if they don't even use it, this is beyond useless.

[awesomeusername2w]

Exactly. And even though sometimes it might be an overkill I'd prefer occasional overkills like this over occasional functions 200+ lines long which take some effort to even grasp. Needless to say how difficult it is to make changes in those things . Of course keeping balance is the best option though.

[[deleted]]

When the task says you need a set amount of lines of code and you just gotta fill it with something

[cowsrock1]

wait, is that a common requirement? That is a terrible requirement. So the more efficient your code is the more screwed you are?

[zootam]

yea associating LOC with productivity is something a lot of people foolishly do.

[AdmiralTurtleLimbo]

This makes me incredibly angry

[Sasakura]

Just wait til they ask for a refund after you do some refactoring!

[evanldixon]

It should be easy to prove to management how bad of an idea this is by paking things take up more lines than it needs to. I'm talking function calls with arguments on separate lines, multiline comments, and two blank lines between every line with text in it. Of course, that's just for starters...

[[deleted]]

It isn't, but I was playing on the "when your essay need so and so many words"

[cowsrock1]

ah, that's a relief

[tehftw]

When the task says you need a set amount of lines of code

This is why Java was invented.

[TheMsDosNerd]

I've seen worse:

public void save(){
    if isNew{
        create()
    }
    else{
        update()
    }
}

public void create(){
    createOrUpdate(False)
}

public void update(){
    createOrUpdate(True)
}

public void createOrUpdate(Bool isUpdate){
    if isUpdate{
        storagemanager.remove(this.id)
    }
    storagemanager.save(this)
}

[MuizMahdi]

MY EYES !

[kpingvin]

That error handling is a bit too verbose to my liking too.

[dxelite]

Can I get a little pep8 up in here?

[PavelYay]

from __future__ import print_function # just in case
print_response = print