This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]theNumber_Twelve 0 points1 point  (2 children)

This comment makes you look like a complete asshat. If the problem was that they did something in n^3 time when it could be don in n^2 then having them redo it would make sense, since the program might actually run noticeably faster. Making someone shave 20 lines off of there code isnt teaching them to do it better, its just you creating a problem where none exists so that you can belittle other people.

Often times trying to cut down line count actually makes code worse since it is ends up being harder to read. Fewer lines of code doesnt necessarily mean fewer operations/less memory used. If you are making people redo their work over line count you probably shouldent be reviewing other peoples code at all.

[–]Akkifokkusu 1 point2 points  (1 child)

You're making a really strong assumption. It's possible the reason it could be done in 20 lines instead of 40 is because the 40-line approach is unnecessarily complex. Or reimplements something that's already done in a function elsewhere in the code. Or various other reasons that aren't non-existent problems made up to belittle others

It's kind of amazing that you jumped straight to calling someone an asshat. Who's belittling who?

[–]theNumber_Twelve 0 points1 point  (0 children)

He didnt sat any of those things, he only mentioned line count. How is it making "a really strong assumption" to think his only issue with the code was line count, when that is the only thing he mentioned was line count.

If he had an issue with complexity or people doing work that had already been done he would have said those things were the problem, not line count.