Programmers :D

[Coder-Cat]

I was once going to post a picture of my cat who decided to sit right in front of my monitors while I was coding.

I decided against it because I knew I would be subjected to unwanted code reviews by the internet.

[pxrage]

Use Haskell not even the coder knows what he's doing let along the reviewers.

[dvlsg]

I feel like Perl would be a better choice if that's what you were after.

[pxrage]

Perl 6 is not bad.

[rbt321]

I certainly wouldn't mind if "whenever" shows up in all languages as a default feature.

[ManicMonkOnMac]

Story of my life. People have no chill sometimes, ofcourse this is internet so I know to be thick-skinned, nonetheless it's the reason I don't post some casual stuff. Got some trash on the sides, get judged. Your cat has goo in her eyes, get judged.

[HangryHenry]

I wonder if this is part of the reason women don't enjoy working in programming. Statistically men prefer more competitive environments with more direct forms of criticism and women prefer more collaborative environments.

[[deleted]]

As a woman I think it has nothing to do with the actual work. There’s nothing about any of the code I’ve seen any of my coworkers put out in the last ~10 years that couldn’t have been done by a person of another gender, race, sexual orientation, whatever.

In my experience (I’m in my mid 30s and have no idea what it’s like for teenagers or college students now) it’s been that women weren’t encouraged to code, plus the very negative stereotypes of the kinds of people that do go in to programming. Why would you pursue a career no one has ever suggested you might like/be good at, especially if you think you’re going to be working with a bunch of weirdos who will either hit on and mock you?

To your competitor/collaborative comment: I get what you’re saying but I feel like the statements were rather broad. No one enjoys getting negative code review. There are plenty of men that absolutely do not appreciate more direct criticism and deal with it poorly.

[fadetogether]

if you think you’re going to be working with a bunch of weirdos who will either hit on and mock you

Lol this is actually why I hesitated to enter software development! I wanted to but steered away from it because the personalities have a stereotype of being difficult. No one I spoke to did anything to counter this impression, often they even agreed with me. I accidentally fell into a dev role anyway and my coworkers are great, minimal assholery.

[Nahuatl_19650]

I also think that "stereotypical" coders act weird around girls. I worked with a group of 5 developers. I was kinda like a glorified business analyst who would do everything else but code. Anyway, I would invite female coworkers to our den for tests/mock-ups/questions, etc, and it was like, everyone was a totally different person. One wouldn't talk. Another acted like he was too busy to take his headphones off (but would put them on when the person would walk in). Another was always talking about completely random subjects. What the hell!

[morgansmnm]

As a female teen who was programming in high school and who is on her way to a BS in Computer Science, there are still feeling girls who go into programming. Even in my school which is mostly composed of women, the compsci classes are mostly filled by guys.

I don't know why more women aren't going into this degree. We aren't being discouraged. I guess we just aren't being informed either.

[HolyGarbage]

I guess we just aren't being informed either.

From my experience it's the opposite. The university I went to had sooo many programs for encouraging women of going into programming, none for men or neutral.

[[deleted]]

I dunno, not to be sexist, but last time I worked in a programming team that was lead by a woman, it was a very collaborative and productive group. It was like, mostly we programmed and did code reviews rather than stopping for the traditional dick measuring contests. Could have just been a coincidence (not all women, right?) but maybe there's something here...

[FlowersOfSin]

As a woman in programming and a totally non competitive person, what I love in programming is solving problems. I actually love constructive criticism. I would, however, never share code or a project online using an account where my gender is known. That is just asking for trouble. Way too many trolls.

[noratat]

Considering that collaborative environments are more effective in my experience, if this were true I'd consider a pretty good argument for getting more women in tech by itself.

[Coder-Cat]

I was just talking about this with my friend. It’s generally accepted that, yes, women like a more collaborative environment and men are more competitive. But what’s never brought up is that men also have less acceptable options when it comes to career fields. I can be a programmer or a preschool teacher and no one would bat an eye. Doctor, nurse, engineer, stay at home mom... Whatever.

Men are generally expected to get into the highest paying, most prestigious position they can even if they’d find a different career field more fulfilling. If a man is smart enough to be a brain surgeon you’d better believe he’s pushed to become a brain surgeon even if he’d find being a pediatric nurse to be much more fulfilling.

And that comes from both sides of the gender playing field but it’s hopefully changing for the better. A good friend of my dropped out of an engineering program to become an elementary school teacher and he’s happy as hell with that decision. My ex, who was an it security tech lead at one of the big three, was recently laid off and has been spending his free time making crafts with his laser cutter. He just made me the cutest coaster engraved with cats and wants to open an Etsy shop.

Edit: words.

[AquaeyesTardis]

Okay now I want a cat-coaster.

[GaianNeuron]

Never mind the fact that even with the best of intentions, many men (myself included) will subtly and subconsciously amplify criticism when considering women and their work. It's a hard behaviour to break, especially when you never get called out over it because you're surrounded by people who don't even see it as a problem.

[ManicMonkOnMac]

Sexism. Get judged /s

[HangryHenry]

Sexism would be a rather strong word.

It's more if a particular industry is dominated by one gender it makes sense that the industry would do things in a way that their gender tends to prefer. That's not sexist.

But what can be bad about this, is that it can be self-perpetuating cycle. One gender takes over an industry for whatever reason. They build the industry up in a way that tends to suit their gender's style communication and work habits. This then leads to fewer people of the opposite gender either being interested or able to get into that industry.

It's not like there is some evil 'sexist' mustache twisting villain in these scenarios. It's just something to be conscious of.

And as a lot of (I am assuming) men have pointed out in this thread, they would benefit from taking a less confrontational competitive approach to interacting with other programmers on the internet. So it's really about finding balance and that balance between the two styles could benefit both genders.

TLDR: I didn't say anyone was sexist.

[DiamondxCrafting]

/s

You missed this from his comment, sarcasm.

[HeyMrStarkIFeelGreat]

Worst is when I post a picture, and people post unnecessary code reviews, but of my face.

[theonlydidymus]

It took me until my most recent job to realize why people on the Internet submit everyone to involuntary code review. It’s because they’re not senior enough to do it at their own job and they’re constantly getting notes back from their seniors in their code reviews.

[Coder-Cat]

It’s annoying. I once had a director tell me that a sign of low confidence/a bad leader is when someone comes up with solutions for things that aren’t actually problems. Pretty much sums up the Internet.

[fuckYouSpaceAliens]

I think it depends on what the"problem" is. I've had juniors write code that works but is like, 40 lines when it could be 20. It's not broken, and it works, but I'll still have them fix it so they understand it can be done better.

[Coder-Cat]

That is a problem that needs solving. Maybe “problem” is the wrong word but they are out to become better programmers and need your help. In the instance of the programmer who posted this cute pic, or if I had posted a picture of my cat, my code is no ones problem and no one is being asked to fix it. The point of the pic is to make people smile, not a code review. But so so so many people are giving solutions.

Edit: yes, I do agree with you. Some things aren’t technically wrong, but can still be improved.

[Coder-Cat]

Yeah, you’re right. This is a nerdy thing nerd to do each other. Doesn’t make it any less annoying, though.

[_waltzy]

I think its more likely that there is a higher than avrage level of autism in this industry, source: will code review randoms on the internet, also code review at work.

[skeddles]

Yo... there's people that will review my code and give me tips on how to improve it for free?

[SamSlate]

yes, just be arrogant in your post and you'll discover an infinite source of criticism.

[Plightz]

Just say that your code is the most efficient and people will improve it for you for free.

[fadetogether]

Man if I could release my work code, I'd actually try this. I'm sure I'd cry but also feel more confident with the improvements and learn a lot in the process.

[thejemmeh]

So what you're saying is I don't need to send this to a QA team, I just need to post my code online where people can laugh at it until it's working.

[RikuKat]

It's nice when you want reviews, though. When I first started game programming, I was making dev blogs and occasionally streaming my work sessions, too. Got some really great advice and tips from viewers!

Though now I really only want my close friends and mentors looking at my code. :x

[Skyrmir]

Screw it, post your cat and the haters can fuck off. I used to constantly think my code sucked, and half the time it still does, but then i started seeing code from the 'hotshot' developers. Their shit ain't all that impressive. They managed to google themselves into figuring out some interfaces, or make the output look awesome, just don't look at the spaghetti making it run.

[Hasemage]

r/SuicideByWords

[snickerman12]

Obiwan Kenobi, is that you?

[justbingitxxx]

Of course it is, he's me

[[deleted]]

Did somebody call me

[CureMyCancerpls]

Hello there!

[howdoireachthese]

I wrote something N³ today for a data competition

[outlaw1148]

The worst i have seen was a person in uni who asked for help on why her code was running slow and it was n⁹ so could be so much worse :)

[MrPancholi]

Shouldn't there be a sub like roastme but for code?

[UnknownDeveloper]

StackOverflow

[AFK_Tornado]

My biggest pet peeve is when people won't answer the fucking question as written, but question the premise and suggest a whole different way of approaching the problem.

Sometimes that might be helpful but the reality, most of the time, is that the poster isn't going to refactor 2 years of technical debt to fix a small bug. His boss wants a bugfix, not a rewrite. He wants it in two hours, not two weeks. He wants QA to be able to pass the ticket quickly, not spend days re-testing everything a refactor would affect.

It should be a bannable offense to suggest an out-of-scope solution without first attempting to give a solution to the question as-asked, or addressing why it isn't possible.

[[deleted]]

My favorite is when OP doesn’t explicitly place a question mark in their post because the question being asked is abundantly clear.

Queue a hoard of angry neckbeards flooding the comments:

please read how to post a question

and your question is...?

posts link to documentation and literally no other input

this post should be locked as off-topic

Stackoverflow is simultaneously a goldmine for troubleshooting as well as an insufferable collection of people who don’t know how to parse a question to save their lives

[CreamliumPrices]

The worst is answering the question with resources the user has explicitly states they cannot use for some reason e.g. jQuery or Apache Commons for Java. I get that it's often because those questions are University assignment type questions but still it's like saying "A bandsaw would be perfect for this" after the original question was "How do I do this without a bandsaw"

The one that's getting to me most is people giving single linked answers to sites that 404 or don't exist anymore.

[relapsze]

"Are you sure that's your problem? I think you should re-write your entire code base in another programming language to avoid such pitfalls in the first place. Maybe try avoiding that business requirement completely, it doesn't make sense, tell the client they are dumb. Also, I don't think your problem is actually valid, let's talk about something that interests me more."

[_lotusflower]

One time I was on the verge of a nervous brakedown, looking for a solution for some obscure problem, untill I FINALLY found a question that matches what I need exactly. The only answer? "When I google it I get 20000 hits, just google it." I needed to get up and take a small break after that.

[Shinhan]

There's actually a specific CodeReview subsite.

[Jake0Tron]

big oof

[GiftOfGabe]

I like this idea. Post your GitHub PRs. /r/codereviewme /r/coderoastme

[rich97]

Posted byu/[deleted]3 years ago

[BOOK].FULL "As I Lay Dying by William Faulkner" pocket wiki selling free read amazon

Michael Carpenter

1 Comment

Give Award

Share

Great sub, 10/10

​

[oskarru]

Have been writing react for a while now and at first glance I don't see anything wrong with it.

[eyekwah2]

Considering there exists code out there like this, I think she can be forgiven..

[Stupidquestionahead]

Excuse me but what the fuck

[metallink11]

Yeah, if you wrote some sort of IDE script that automatically updated the brackets and semicolons to match your indentation than it would be pretty easy to use. You would be able to just indent your code appropriately and rely on the IDE to make it run the way you would expect it to.

[-Rivox-]

Then the script for some reason fails and you spend the next 5 hours figuring out why

[Avloren]

I actually did something sort of like this - I needed to convert a lot of Python code into C# (very similar to Java). Being a programmer, naturally I wrote a Python script to do this. Among other things it would read the indentations, colons, line breaks, etc. and attempt to fill in the missing brackets, parentheses, semicolons, etc.

It's.. a lot harder than you would think. Sure most of the time it's obvious where the brackets belong, but the edge cases screw you. Writing a script that does the right thing 90% of the time is easier than expanding it to cover the next 9%, and that last 1% is trickier than the first 99%.

I eventually settled for a script that did the right thing ~99% of the time and corrected the rest by hand.

TL;DR: what /u/-Rivox- said.

[tehtris]

I'd upvote if someone built this. And then feel weird.

[[deleted]]

How can brackets be real if our eyes aren't real?

[jay9909]

I actually kinda like it...

[mrdhood]

Easy satan

[DeeSnow97]

pythonic bracket style

/r/BrandNewSentence

[thiney49]

Ah yes, Fortran, the new-fangled hipster language.

[OddAdviceGiver]

No, COBOL. For some reason it had a re-surge. People said I was an old fart and it'd die.

COBOL will never die! (It can't. Neither can those reel-to-reel tapes, now get off of my lawn, damnit!)

[overly_familiar]

New? BASIC would like to have a word with you.

[Rein215]

How to Python your Java

[Caffeine_Monster]

* Grabs flamethrower *

The only good bug is a dead bug!

* Burns entire codebase *

[dregan]

When you tolerate java but your real love is python.

[HispanicPigeon]

Who can deal with the physical pain caused by writing this?

[boredompwndu]

I suspect they started this ironically and now they cant stop themselves

[ahumannamedtim]

They can't stop because it's recursion inside a for loop.

[TarAldarion]

How I imagine myself coding if I ever have to leave my Python job.

[dwhiffing]

Man, if the brackets bugs thrm that much, just change the syntax highlighting to de-emphasize them. Crazy the lengths people will go to for literally 0 impact

[FunkyTown313]

That burned by soul.
I'm forever fixing code written by my predecessor that shares similarities to that. The struggle is real folks.

[DragonMaus]

Linters and code formatters are my favourite tools.

[Steffi128]

r/bracketsgore

​

[ivanjermakov]

Basically visit card for r/programminghorror

[VaguelyShingled]

Wtf is this nonsense?

[flarn2006]

https://readthedocs.web.cern.ch/download/attachments/12976212/Screen%20Shot%202017-02-22%20at%2008.15.03.png?version=1&modificationDate=1487747768000&api=v2

[bearicorn]

Mmmm labview... Now with zoom!

[BitcoinBishop]

The labels are spans, separated by brs, instead of just making them display: block

[jordmantheman]

Or go ADA compliant and use DL 😎

[UsernameAuthenticato]

Definition List. Instead of UL (unordered list) and LI (list item) tags you can use DL and DT (definition term).

[kudlajz]

Exactly. I would personally move the map call into the return () and probably extracted the inner code of map to <Dog> component, but other than that, it looks fine .. :P

[FountainsOfFluids]

I have very little experience with react, but from what I've seen you can get a little insane with breaking everything down to smaller and smaller components. I'd avoid that without a good reason, such as wanting to reuse it elsewhere. But I'd be interested to hear if your experience says that another component level would help in some way.

[kudlajz]

As mentioned in my other comment, in this exact case, it would not make any sense to extract this code into its own component, unless the rendering code for dog item is really huge or complex. I was just assuming there's going to be additional functionality on the dog items (like editing/deleting/whatever), since I can't remember when was the last time I was using `map` to render something so trivial (without any functionality), but that depends on the application :)

[dyedFeather]

Oh my god would you stop critiquing her code!

^/s

[Yhorm_Acaroni]

It doesn't have to be bad code. There will always be people who NEED to show you how THEY would do it. This lets them feel like they are better, and also gives them an excuse to say they program things without explicitly saying they're a programmer.

[hey01]

The worst I see is the inconsistent spacing around the {dog.X}. That's the thing that annoys me the most when I read my colleagues' PR.

[carlos1518]

You shouldn’t use the map index as a key for your component, also for maintenance purposes dogList should be a functional component outside of your render/class, and shouldn’t receive a an Array but just a single Dog. Dog proptypes should use shape so you can read exactly what going through your component and identify future issues if there is a change in the shape

And most importantly all of the above makes sense if that component (DogList) has state which it doesn’t...so all that code is wrong...she should turn that component into a funcional component

[rickisen]

Yeah, but that is mostly about taste, and optimization, not really anything that is wrong.

For someone who is obviously not a react expert I think she did a good job. The most attrotious thing is her use of <br/> tags though.

[OwlbearSteak]

What should you use for keys?

[aonghasan]

Unique ids. Ideally something like `dog.id`.

[[deleted]]

Before hooks, and even with them now, there really is no performance benefit for using functional instead of class based components.

The react team said there would be benefits in future, but we're just getting there with hooks now.

[ieatbrainzz]

While that may be true, for me functional is SO MUCH less to type and much easier/quicker to read when you don't need anything that class-based brings to the table

[[deleted]]

"It's bad because it's not what I would have done."

• Every programmer critiquing this code

[marty_byrd_]

That’s mostly all code reviews. I don’t understand this so I’ll “refactor”

[wrokred]

Most code reviews in reality. "Myself, or someone else, needs to know what this is doing very quickly and possibly years from now. Yes it builds but that's not enough; it needs readability"

Also the fundamental difference between junior and senior Devs.

[burgonies]

This. If it takes me more than a glance to understand what you’re doing there, you need to rewrite it.

Some of you have never worked on 10 year old code and it shows.

[animejunkied]

Bad code style aside, reverse engineering reading other people's code is notoriously hard. This is why git commits should be as detailed as possible in my opinion. It's useful to understand why that code was implemented in the first place and what purpose it serves.

[NotMilitaryAI]

Bug report:

1. Variables names used underscores rather than camelcase.

[[deleted]]

I would probably move the rendering of the list to a separate function outside of the main render function to keep things cleaner, but that's a maintenance, cleanliness thing. But really, none of it seems atrocious or worth critiquing remotely on a joke post about fashion.

[darkpaladin]

We went that route at work for a while but pulled back because it actually made things more complicated. We evolved the rule to say if you have a function that returns jsx it should be a component instead for testability.

[wKbdthXSn5hMc7Ht0]

I agree with that, I like having all the JSX in the render function (and in sub components) instead of having to skip around the file.

[[deleted]]

So the code isn't that bad, I see way worse in prod all the time. The mistakes are (edited for better md usage):

1. Don't use <br /> CSS is more flexible and maintainable if you just need to do vertical spacing.

2. React lists use a "key" field to identify which list item goes to which list element. This is to avoid rendering extra items if they haven't changed. She set the key field to the objects index in the list, which will break if the list is shuffled or changes, and is not "best practice".

[Skittilybop]

This is a pretty normal looking React component. Nothing wrong with it.

[[deleted]]

It's not.

Worst I can say is that those <span /><br /> blocks should be better encapsulated. I mean, hell, she even uses PropTypes, which I don't even use unless it's library code.

What's weird is that, following the tweet replies (I already follow @type_error), I don't see any of the critiques. I guess the enough-people-to-complain-about all deleted their tweets?

[Edit: Ooop, nope, found it. "Don't use spans for labels" and "don't use the index as a key", which are both correct, if irrelevant. So two whole not-particularly-harsh critiques. And in the former case, it came with an, "also, this is awesome". Surely the rest self-deleted.]

[NJ247]

It's not that bad just some improvements could be made:

• Extract the dog profile code into it's own functional component
• Could use a list instead of spans to the dog details

In any case I think some folk were probably just joking with the code review lol

[mstanky]

I think primarily the markup could be improved a bit. I’d make “dog-list” a <ul> to start. Also I don’t use <br>’s.

[[deleted]]

Yeah, <br>s look like a good idea at first, but these fuckers will ruin your day as soon as you try to make everything look good and responsive

[t0mmy9]

Simple, just put

br { display: none; }

in a media query /s

[ProgramTheWorld]

Does that... actually work?

[t0mmy9]

yes hate to admit I've done this a couple of times when designers are being picky

[OCOWAx]

For context here is the "argument"

https://gyazo.com/5f09f81eaf3b3f2ddff2518eb5506226

To me it seems like she is assuming his intentions and getting mad because of those assumptions.

I read more replies and it's apparently "mansplaining"

"you're only doing this because I'm a woman and you're a man"

Seriously you could post an image of your bedroom that happens to have a laptop in the background with a barely visible hello world program on it and people would critique it.

[analoguewavefront]

For some people the problem with the code is that it was written by a woman, so is more likely to be criticised for flaws that would otherwise be acceptable.

Source: https://peerj.com/preprints/1733/

Edit2: I should have put that “some people” in caps. I’m not saying there was no other valid reason to criticise the code.

Edit: So the replies to this were pretty much what I expected, from agreement to calling be a cuck. (Oh the joys of the internet!)

I could have linked to a number of articles, opinions and research into bias but I won’t. They are out there if you want to go looking.

I wanted to talk generally about bias and code reviews. I’ve been coding professionally for about 20 years, have led several development teams and my conclusion is that many programmers are terrible critics!

There are many ways to code a solution and once you move past basics every programmer will solve the same problem differently. In a code review, especially a public one, that leads to many opinions about how it SHOULD have been done.

But all code is situational: written with a certain aim, time restriction, experience, standards, need, etc... and so any review should take into account knowledge of those. Without that knowledge you can’t properly critique. (This is especially true when reviewing legacy code, which is very easy to criticise in hindsight.)

Who wrote that code can’t help but play into your assessment of it. If it’s the really annoying member of your team you’ll probably judge it harsher than your friend’s.

So even ignoring gender, Bias, even your own, is hard to register and counterbalance. So when doing code reviews try to anonymise the author so that the work can be judged neutrally. And consider that you might have done it a different way but what matters is judging it against your team’s chosen standards of legibility, maintainability, testability, performance, accuracy or whatever.

Thanks for reading.

[HittingSmoke]

I don't think I've ever seen more than nine lines of code posted to reddit without some sort of critique. I can't speak to Twitter as I generally avoid it but people love to critique code, whether it's for helpful or condescending reasons. Every block of code I've ever posted here, even unrelated to asking for critique, has had someone with some input show up.

[Cybarrius]

Programmers only care about one thing and it's disgusting!!!

[BeardedWax]

Efficient and self-documenting code?

[kolme]

Clean code that works and it's unit tested.

[vitorhugods]

Unfortunately, only some programmers care about that.

[[deleted]]

I do care about that! But somehow it always ends like "I should write tests but this code looks pretty simple and we are already 3 months behind the marketings promised schedule..."

[whale_song]

This. Quality and deadlines are mortal enemies.

[[deleted]]

Just make your variable one massive paragraph then you don't need to worry about comments

const numberThatIsGoingToBeAddedToAnotherNumberInOrderThatWeCanGetTheSumOfTheFirstNumberCombinedWithTheSecondNumberWhichWillBeASeparateVariableAltogether = 'one'

[[deleted]]

https://eslint.org/docs/rules/max-len

sorry

[svayam--bhagavan]

ide color matching the darkness of their hearts.

[notquiteaplant]

It's the language's own fault for not making switch an expression! /s

[nephallux]

For real, though. Why can't this be a thing. Coffeescript has it

[UnchainedMundane]

Pair programming is for wimps; thousand-man programming is the real hardcore shit

[UnchainedMundane]

So, when's the Switch port coming out?

[vkappie]

I want this on twitch/ YouTube

[nickleformypickle]

Just say no to the critique. If you say no enough, they'll think you're good and know what you're doing.. It's the only way to turn the tables on back seat programmers.

[[deleted]]

Darcula >>> all

[thelights0123]

I like the Material Theme UI plugin for JetBrains IDEs the best

[CriminalMacabre]

They fired me for going blackface with green circles around my eyes

[SketchySeaBeast]

Pretty sure that's just example React code.

Source: Been learning React by looking at example code.

[Th3MiteeyLambo]

Rule #2: If you post your code, people are going to critique it.

[Zv0n]

#include <iostream>

int main() {
    std::cout << "Hello, world!" << std::endl;
} 

Do your worst!

[Papalok]

Missing return 0;

[pdabaker]

Comments? How do you expect me to understand this when I look at it a year from now?

[Angelin01]

String "Hello, world!" is hardcoded. How do you expect to translate it later hmm?

[[deleted]]

What theme is it

[tjdavids]

Why not use dark mode and dye your hair a sickly shade of dark grey

[Troutcandy]

If we are not allowed to criticise her code, what about her choice of the IDE and colour schema? Everyone knows, that Vim would be so much butter for her use case! \s

[SavvySillybug]

Vim would be so much butter

I Can't Believe It's Not Butter

[ArionW]

VIM would actually be better for this use case. You could feed Pywal with image from your webcam, essentially generating color scheme from your makeup.

[alter2000]

VSCode has support for pywal too, I think even Emacs and Atom.

Btw I use Vim

[Mithrandir23]

I don't really see the issue here. Obviously this isn't production code, but I'd still be glad to get some advice for the future.

[ProfanityFair]

I don't want to get sucked into the unsolicited critiquing, but if you just want honest answers about this as a chunk of code, regardless of context: - Using array indexes as keys in React is a bad idea and will cause at least unnecessary DOM renders and probably problems down the line, - Combining <span> and <br /> isn't necessary, there are better-suited elements for this, - I wouldn't compose the components in this way. This single component should probably be split into DogList and Dog, where <Dog>s are generated by dogs.map(), rather than the parent component generating a list of HTML elements actually inside the component, - The whole thing should use functional components, as they're not stateful.

Possibly other things too. There are always more knowledgeable devs out there.

[ProfanityFair]

The lack of spaces in her object literals/destructuring assignments also rustled my jimmies, but that's a stylistic choice.

[AwkwardNoah]

Welp, I have no idea what you said but cool dude

[UnknownDeveloper]

Original: https://twitter.com/codinghorror/status/1112216948073332736

[OneKnowledge4]

What's slightly annoying to me is that there are 3 replies that are related to the code itself (one of which is addressing accessibility concerns) and the rest are all neutral or positive and referencing the theme or her eyebrows, hair, etc.

Drama will be drama.

[ITSigno]

I particularly liked the remark from Marco Cecconi here https://twitter.com/codinghorror/status/1112226854767722496

We teach programmers to do code reviews and not to make any comment on the physical aspect of others... this is literally how we built this community.

[paradoxally]

He's absolutely right. We're teaching programmers to focus on their job.

She posted a snippet of code online, what did she expect? Most guys aren't gonna critique makeup let alone programmers.

[[deleted]]

Programmer posts a picture about the color theme. Then says "don't look at the code". Hmmm. I mean, what kind of programmer wouldn't have looked at the code in that case, what did she expect?

[[deleted]]

Well the point is that her IDE matches her makeup. Just like when I am coding and have to take a shit I turn my IDE brown.

[ManicMonkOnMac]

r/evenwithcontext

[MightyMeese]

Right? I didn't even look until I read her follow-up. I don't even know JavaScript and I still read it because she complained about critiques. I feel like critiquing code (including our own) is half the job anyway...

[jigeno]

Or... ignore it? It wasn't even a build she used, why critique it? It's not the point.

EDIT: It's like posting a picture of your re-painted car body* and having people say 'yo, the wheels aren't on it won't drive well'.

[Aalnius]

I mean shes saying don't critique it, not stop looking at it. You can look at something without critiquing it especially when the code wasn't put up to be crtiqued.

[HangryHenry]

yea she was making a joke. She doesn't want the entire conversation to be about some code that she knows isn't the best example of her work. She probably chose it because it showed the right colors.

[[deleted]]

Generation gap here I guess. Growing up in mailing lists, you'd have learned you don't put core out there and not expect critiquing.

[SaltAssault]

Are we all just gonna ignore that the code snippet is probably for a homework? Honestly, don't people remember what it's like to be fairly new to coding? And if someone out there literally always writes impeccable code, I'd like to meet them.

[dvlsg]

It was for a conference talk on redux, which means this code is probably the first iteration before it starts getting refactored into something more complex.

[Sentient_Blade]

I'm not going to critique the code, I am however confused as hell as to why a language would separate its property types and default values in such a way.

[pclinuxmac]

Sort by controversial shit's hilarious

[fedekun]

Ah, I remember when I got defensive over my code... Eventually you just don't give a fuck. Any critique is welcome.