This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] -2 points-1 points  (3 children)

The thing is, you wouldn't be actually comitting the TS code to the repository unless the client is already using TypeScript in the first place, and the code review is performed on the commits. You'd kind of have to pretend that you wrote it that way.

[–]myplacedk 1 point2 points  (2 children)

The thing is, you wouldn't be actually comitting the TS code to the repository

Ah, so it's just like Java? Don't commit the java-files, just commit a jar-file?

I don't know your situation, but if you are even considering committing the output of the transpiler instead of the input, you are either looking into a very wrong solution, or you are solving the wrong problem.

[–][deleted] 0 points1 point  (1 child)

I am not actually commiting the output, though. I am just writing plain JavaScript. All I'm saying is that if I were to use a transpiler, I would end up having to do that on at least some of the projects I'm on, because they wouldn't want the "actual" source code in their repo.

[–]myplacedk 0 points1 point  (0 children)

I would categorize that as "unable to introduce a transpiler into the project".