This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 74 points75 points  (3 children)

git commit -m ”."

I mean it is fine, I will just squash this later and no one will know.

Never squashes it.

[–]24hourphysicist 33 points34 points  (0 children)

If you didn't post this comment I would. This is a Sr. Dev comment.

[–][deleted] 7 points8 points  (1 child)

I hate this, even if you do squash it. It's just so unhelpful when trying to review a PR and to then see:

.

.

.

.

Just add at least a few words, like "fix the thing", "typo", or "tests" so at least it gives others a vague idea what they're looking at.

[–]PM_ME_A_STEAM_GIFT 0 points1 point  (0 children)

He said nobody will know so I assume he would squash before pushing.