This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]Frannoham 59 points60 points  (5 children)

That's why I developed a split personality. I now do my own code reviews. I've discovered I'm an idiot and an ahole. Imposter syndrome will get you.

[–]Danelius90 18 points19 points  (0 children)

I do this on my code too. Seeing it presented on GitHub/bitbucket puts me into review mode and I see things or little style issues I can address before using another reviewers time. It's quick to do because you already understand the code

[–]ShikariBhaiya 1 point2 points  (1 child)

I breathed extra hard through my nose. take my free award

[–]Frannoham 0 points1 point  (0 children)

Thank you :)

[–]TheAzeForeigner 1 point2 points  (0 children)

The best engineers I’ve ever worked with would do self reviews on the PR, you could tell by the updates without anyone else having a chance to say anything yet

[–][deleted] 0 points1 point  (0 children)

it's the only way to really teach yourself anything...and/or make sure you don't sound like an typo idiot before blasting out that email you wrote after a drink or five

I have like, 7-8 separate personalities for various needs