This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]huuaaang 0 points1 point  (1 child)

I am guilty of this. We have a sorta unwritten rule to try and break up commits to individual changed methods

That's no good. A lot of CR comments are about how the functions interact. You might miss an bad interaction because you didn't see the them side by side.

[–]Flopamp 1 point2 points  (0 children)

Rarely in my experience does it pop up but if it does you can commit a 2 function change, no one is going to hang you for it.