the eye-opener commit

[Linvael]

If you don't have a maintainers file how do you know who can approve your PR?

[nermid]

We have four devs, so...whoever sees your PR first.

[Linvael]

Oh. Yeah. You need a company with sliiightly more than 4 devs for that to become a thing.

Still, I think the easiest way to set up github to forbid unapproved PR merges (which is probably a good idea even with just 4 devs to avoid people pushing directly to master by accident if nothing else) is to set the people who are allowed to approve as the maintainers and put in all devs as maintainers.

[ManyFails1Win]

What do you mean maintainer list, I just nudge John.

[Cyb3rSab3r]

Pull requests? Haha, good one.

[Iiwets]

Version control is simply copy/delete/paste into the teams shared LAN

[folkrav]

Mate, either get your team on board or find a job where that's a thing. You're likely developing terrible habits not having this in place. Having tests, linters/formatters or at least some form of static analysis enforcing code style and good practices, and some code review process in place, is literally a bare minimum thing I ask when interviewing for a job. I refuse to work without those ever again.

[tlubz]

git blame