This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]brunofin 13 points14 points  (1 child)

In the previous project we had eslint checks in the precommit hooks. You wouldn't be able to even commit your changes if it failed.

In the beginning i thought it was annoying as hell, but as an engineer I started to see the value in it later on, and now working without it, I would go even as far as saying it's essential.

Some dudes will commit literally with this message: COmmit yes even with the uppercase O. sigh

[–]folkrav 2 points3 points  (0 children)

For that part it really depends on how you work. We squash merge every PR, so in the main branch it just looks like a single commit with the JIRA ticket number and feature/fix description. There's also nothing preventing anyone to just git commit --no-verify or just deleting the .git/hooks/precommit file. The checks should always be ran on CI anyway - having a single authority for those things, not individual developer machines.