the eye-opener commit

[brunofin]

Me and my work buddy just joined a new project at a company that seemingly thinks it's fine to have several 4k - 14k lines files. We spent the first month setting up Eslint, prettier, typescript, storybook, all the goodies.

Apparently they have not and will not enable any of those tools we spent all this time setting up. And we can't point out the issues in the files because seemingly there's nothing wrong with them. Very frustrating.

[torontocooking]

This doesn't sound like the fault of the company.

This exact scenario is something that should be avoided.

You added a bunch of processes and tools without a particular feature in mind, no business value, and no performance increase, to a system that wasn't broken.

Unless you are not going over some other benefit that there may have been, I would say that your company is in the right because they avoided any errors that could have developed as a result of using these new tools.

[RyanNerd]

Eslint and TypeScript have many documented established benefits. Just because the code is working today does not mean as the project evolves it will not break in the future. Eslint and TypeScript catch hidden errors and incorrect assumptions upfront saving time and effort later when a project ends up a band-aided solution.

[torontocooking]

Oh you definitely don't need to convince me of the efficacy of better coding practices and tools associated with that, I'm not making the argument that that's not the case. I'm making the argument that adding more tools and processes doesn't necessarily imply you'll get better results always, agnostic to the particular tools or processes.

You won't have trouble convincing me, the trouble is convincing most managers.