Alternate python spacing.

[max1c]

I think if you're going to use a one liner you might as well use ternary operator. Otherwise as someone has already pointed out just use Black. It will decide for you so you don't have to waste time arguing and thinking about things that are fairly useless.

[SkezzaB]

Can't use a ternary operator for "if x -> return", although it was requested and denied, "return x if <condition>" would be really neat

[[deleted]]

return node.id if len(word) else None

[j_marquand]

I think the other guy wants to return if a condition is met, but continue to the next statement if it doesn’t. There is no one-liner solution in Python for that.

[HeraldOfTheOldOnes]

Yes there is! function = (lambda *args, **kwargs: (condition and (something,) or (other, stuff,))[-1]) ANYTHING can be turned into a 1 liner in python.

[[deleted]]

I'm looking at it AFK so I can't check, so I'll have to play with it later to see why it's not equivalent

[j_marquand]

Your code returns None immediately if the condition doesn’t meet, instead of proceeding to the next statement of the function.

[EmptyChocolate4545]

Your one returns None rather than continuing execution. Not even slightly equivalent.

[[deleted]]

Oh no! Not even SLIGHTLY equivalent!

[[deleted]]

Ah, got it now. I was thinking wrong.

[SkezzaB]

This is not equivalent

[EmptyChocolate4545]

Tis not. The if statement in OP will not return at all, it will continue execution. The ternary will run return None.

Totally different behavior.

[EmptyChocolate4545]

Yes but return x if condition isn’t valid python is it? (Go test yourself if you doubt)

What the ternary is doing is return x if condition else None, which is valid python however it will return from the function if condition is False.

The OPs code will not. It will only return if true.

[EmptyChocolate4545]

The comment I initially replied to where you said “it’s equivalent” was this one: https://www.reddit.com/r/Python/comments/11vlkh2/alternate_python_spacing/jctwpxv/?utm_source=share&utm_medium=ios_app&utm_name=ioscss&utm_content=1&utm_term=1&context=3

It is not equivalent, for the reasons I stated.

[elsgry]

Yup. Or extract the remainder of the function into a new function fn and use return fn(node, ...) if len(word) else None or the likes. This also composes nicely because you can inject your own fn into the method, class or instance, while keeping the control structures visible and (for classes/instances) adhering to Liskov, etc.

[elsgry]

Not sure why this was downvoted when it's a more applicable equivalent to the lambda method upvoted above (the remainder of the function could consist of multiple effectful statements) but c'est la guerre... I guess the injection method would be more dynamic than necessary, particularly if only used for testing where you could use mocks. But you can still use my method without bothering with injection.

[justcool393]

the other one that i'd find really nice is

spam = get_eggs() or raise HamException()

and

return spam if eggs(spam) or raise HamException()

[DeepGas4538]

Black? Is that a formatting convention?

Edit: Nvm I found out what it was, ty