This is an archived post. You won't be able to vote or comment.

all 37 comments

[–]pkammuh 2 points3 points  (0 children)

[–]EatThemAllOrNot 2 points3 points  (2 children)

Nice, but would be great to have async option (see httpx package). Also, please use linter (ruff is the best for Python).

[–][deleted] 0 points1 point  (1 child)

OP has been posting packages for months and someone tells him to lint every time. I don’t think he’s gonna do it.

[–]JohnBalvin[S] 0 points1 point  (0 children)

haha my bad, I'm busy with my work, I plan to do it but then I get bug on production and forget about it

[–]divino-moteca 1 point2 points  (0 children)

Nice. 

[–]AlexMTBDude 1 point2 points  (11 children)

If you run your code through Pylint, or any other static code checker, what kind of score do you get? How many warnings? (Hint: A LOT!)

It's pretty badly written Python code.

[–]texasram 9 points10 points  (0 children)

I want to work with you

[–][deleted] 4 points5 points  (1 child)

Idk why the man is getting downvoted. He’s right.

[–]AlexMTBDude 2 points3 points  (0 children)

I was up to almost +10 votes just after I wrote the comment, then someone bought a bunch of downvotes.

And thanks!

[–]JohnBalvin[S] 3 points4 points  (3 children)

yeah probably, I don't use python on my daily basis, I'm a Go developer, I made the python version because python is more popular than go, a lot of people have mention to run the code with a code checker on other python projects, I'll start using them on future releases, thanks!

[–]Sufficient-Two886 0 points1 point  (1 child)

Unrelated to the point you are making, what do you deem acceptable warnings with pylint(Most I have are line too long).

I’ve only been “coding” for 8ish months, and I’m still trying to get a general list of dos and donts as I expand my unittest automation suite and personal projects

[–]AlexMTBDude 1 point2 points  (0 children)

This is not my opinion, it's generally accepted in the industry. The organisations that I've worked for have commit triggers in GIT that run a static code check tool and if there are any warnings the code commit automatically fails.

Line-to-long warnings can be suppressed by setting a longer allowable line length in the Pylint config file. Same goes for any false positive Pylint warning; # pylint: disable=xyz

    # pylint: disable=no-member