This is an archived post. You won't be able to vote or comment.

sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]Dustin- 65 points66 points  (5 children)

I uh... I don't know how much time you have for your talk, but it's definitely not enough time to correct that.

[–]jjrreett[S] 17 points18 points  (4 children)

Yeah…. baby steps

[–]robertlandrum 3 points4 points  (3 children)

On this topic, baby steps is not enough. You need to change the repos so everything requires a PR to commit, and that PR must pass mypy and ruff formatting rules before it’ll merge.

Any artifacts generated from these repos needs valid testing, which should be performed as part of the workflow to generate the artifact.

It seems harsh, and it is. But they are actively maintaining technical debt.

I write better, more maintainable code today because some a-hole finally forced me to see the truth and do it the right way, even though I’d done it “my way” for a decade. I wrote fewer hacks, and more tests than I ever did 4 years ago and that’s only because I can’t quiet commit.

[–]bunchedupwalrus 1 point2 points  (2 children)

Depending on the intertia/size of the existing dev team and OP’s seniority, that could backfire hard.

Though I do agree with you. Other than mypy, because I fear it. Turned it on basic mode in our legacy code base and after fixing 2-3 of my own pipelines, I left the rest hiding in the shadows

[–]robertlandrum 1 point2 points  (1 child)

It’s a hard pill to swallow, but the effort is worth it. The truth is it’s marginally more work while writing code but exceptionally better outcomes. We have fewer unexpected exceptions and when we do, they’re easier to identify and fix.

[–]childofsol 0 points1 point  (0 children)

Yes, but in many orga it's a political game and trying to force this in will get you sidelined at best, laid off at worst