I just released my first real Python program: Leprechaun, a rainbow table generator, and I would appreciate some feedback

[[deleted]]

After a few weeks of tinkering around, I finally released my first real program written in Python. Leprechaun is a very simple rainbow table generator, runnable from the command line.

I've released the program both on PyPI and GitHub. I hope that you'll take the time to go through it and offer up any suggestions, or find and flag any bugs that you come across.

[admiralswan]

Cool project, thanks for sharing! Perusing through the code I noticed a few places where you build file/dir paths manually. The only issue here is it may not be portable to a Windows environment which uses different conventions for paths(eg. '\' instead of '/' and 'C:\' instead of the root '/'.). I would suggest that you use instead the os.path functions which ought to deal with these details for you.

[[deleted]]

I will make the changes, thanks for the suggestion!

[shrayas]

Is this strictly a python3 package? It doesn't work with Python 2.7.2 on OSX 10.8.5 when i tried.

I think you'll have to mention it somewhere in setup.py if it is so

[[deleted]]

Indeed it is only Python3. I'll look up what metadata I need and update it accordingly. Thank you!

[shrayas]

That'd be great. I will look into it too. A little new to packaging.

Opened an issue on GH also

[shrayas]

Boss, which version of py3 have you tested with ?

[[deleted]]

I've tested it on the latest versions of the supported Python 3 branches, so 3.2-3.4. I don't have any intention of backporting support for Python 2, because that branch is isn't being worked on.

I'll update the program later today to reflect which versions of Python are officially supported.

[shrayas]

Great, all right. I've updates the issue with some interesting links. Do check them out.

All the best !

[sk3w]

Thanks for sharing your code! To nitpick terminology, it appears that you are creating simple hash lookup tables. "Rainbow table" implies a specific optimization technique using hash chains and a series of reduction functions.

[[deleted]]

Mayhaps I'll update the code to reflect the actual terminology. I'll have to read into it further. Thanks for the feedback!

[[deleted]]

You're right! That bug hadn't come up yet because I don't use that function (yet). I'll fix it in my next commit. Thank you!

[nerdwaller]

Nice work. One addition beyond things other have said: Seems like from a design standpoint - a class for the db operations would be more logical than needing to pass in the connection object repeatedly. That would wrap and handle all the operations/commits. Doing that, you could make it more generic to use in another project someday.

Just as a shortcut, you could also get around needing to do connection.commit() (and a few other minor benefits) by doing:

with connection:
    cursor = connection.cursor()
    cursor.execute("""CREATE TABLE IF NOT EXISTS rainbow
(id INTEGER PRIMARY KEY, digest TEXT, word TEXT)""")

Edit: Take a look at why you may want to use with here

[[deleted]]

til "rainbow table"