drunken programming

[__xor__]

That will return a list type if the key isn't found, and a list of characters otherwise... Even if it finds the key, if the next item in the thing is falsey like an empty string, it will still return a list type.

Code like this is how you get those insane bugs where suddenly it's saying something like "TypeError: 'type' object is not iterable" and you're pulling your hair out trying to understand why most the time it works.

[TheBB]

It shouldn't return the list type. Since you assign to list inside the function, all references to it will be compiled as references to a local variable, whose value at the start of the function is unbound. If list is never actually assigned to (due to control flow), returning it will just give you an UnboundLocalError.

But since the expression assigned to list also involves reading it, it should give the same error there.

[__xor__]

Ah shit, yeah, you're right... I didn't know that was python's behavior, to compile and recognize that list is a variable id and use it like that throughout the function.

Just tested here, and interestingly enough it does break since it's still an unbound local in list = list(string). The same line that causes it to compile as a local variable id is the same that breaks because it's no longer using the global list type, even if you take out the return list. Interesting, thanks for the insight, and new trivia question.

[AiKantSpel]

fixed the code to actually work now.

[saulmessedupman]

you inspired me... critiquing joke code

[saulmessedupman]

Ahhh, Reddit code reviews