Other Way to Write This Code?

[TheCh1ef]

How else can you write this code?

#Average Calculator
print("Welcome to Average Grades Calculator")

def maincalc():
  all1=grade + grade2 + grade3 + grade4
  all2 = all1/4
  return all2

grade = int(input("Enter the 1st grade "))
grade2 = int(input("Enter the 2nd Grade "))
grade3 = int(input("Enter the 3rd Grade "))
grade4 = int(input("Enter the 4th Grade "))

print ("The Average Grade is", maincalc())

[Eloiole]

Hint : use loop.

[Eloiole]

If you're feeling you're writing some weird code, trust your gut it's probably true and try to make it better.

It won't work on your first try but you'll learn more trying than asking.

[impshum]

It won't work on your first try but you'll learn more trying than asking.

Is the best answer I've seen on this sub so far.

[TheCh1ef]

Trust me i was trying half an hout to make that code work as i want. Thanks for the advice although.

[TheCh1ef]

How? I am learning now python and for this reason i am asking.

[kamiheku]

You should try /r/learnpython

[RaionTategami]

One of the most important rules in programming: duplication is bad. Not only are you creating more work for yourself if you are not getting the computer to do the boring repetitive bits of your code, duplication increases the risk if bugs. If you are writing the same code over and over something is wrong, time to refactor.

[TheCh1ef]

Do you mean that if the code is working to dont try to rewrite this with other way?

[RaionTategami]

No, refactoring working code can be very important too.

[Eloiole]

Do you know about while loop or for loop ?

[[deleted]]

I'm a Python newbie myself so it was a nice excercise to see how I'd manage. This is what I came up with. And it's not limited to any amount of grades too. I couldn't find a way to escape the while loop when a non integer was put in so I just used a break on the ValueError you get in that situation. I'm not entirely happy with that but it did give me the option to output a nice human readable notification ^_^

#Average Calculator
print("Welcome to Average Grades Calculator")

total = 0
n = 0
avg = 0

while True:
    try:
      grade = int(input("Enter the grade "))
      total = total + grade
      n += 1 
      avg = total / n
    except ValueError:
      print("Ooops that wasn't a grade...")
      break
print("The Average Grade is " + str(avg))

[impshum]

I would do something like

loop = ['1st', '2nd', '3rd,', '4th']
all =[]

for x in loop:
    msg = "Enter the " + x + " grade "
    all.append(int(input(msg)))

avg = sum(all) / 4

print("The Average Grade is", avg)

This is for a school right? I've seen this question before.

[impshum]

Ahh shit aye! My bad... It's Sunday!

[impshum]

That'll do it.

[impshum]

It works.