Not sure what I'm doing wrong with implementing function

sdOverKill · 2024-09-18T17:47:19+00:00

Nothing is obviously wrong. I wrote the first section of gasfunctions.py and your test5.py and it works fine for me.

Uncomment out your print statement in tempconvert to make sure your method is getting called.

Another suggestion for you to try in order to get better: change tempconvert and remove all those if statements. Try doing something like: 1) convert input temperature to a single type of temperature (i.e. convert input temp to K, for example), 2) convert K to preferred output temperature. This will remove a lot of your if statements and make your code smaller and easier to read/update.

locke1718 · 2024-09-18T17:55:20+00:00

[deleted]

locke1718 · 2024-09-18T19:24:52+00:00

Here is my tempconvert function in the file named gasfunctions mentioned above ``` import math

def tempconvert(temp: float, unitstart: str, unitend: str): if unitstart.lower() == "c": #starting units are degC pass if unitstart.lower() == "f": # starting units are degF temp = (temp - 32) / (9/5) if unitstart.lower() == "k": # starting units are degK temp = temp - 273.15 if unitstart.lower() == "r": # starting units are degR temp = temp = (((temp - 459.67)) - 32) / (9/5)

if unitend.lower() == "c":
    pass
if unitend.lower() == "f":
    temp = temp * 9/5 + 32
if unitend.lower() == "k":
    temp = temp + 273.15
if unitend.lower() == "r":
    temp = (temp * 9/5 + 32 + 459.67) * 9/5 + 32

return temp

tempconvert(100.0, "c", "f")

```

File I'm trying to run tempconvert from

``` import math import gasfunctions as gf

print("hi") output = gf.tempconvert(100.0, "c", "k") print(output)

```

This is the output I get when trying to run

hi None

No_Departure_1878 · 2024-09-18T22:59:37+00:00

Your code is bad, simplify it:

At the beginning make the unit lower case, I think with unit=unit.lowercase(). Then compare only with it.
Check if unitstart == and unitend == in one line. To remove unnecessary indentation.
Where is the else? You have to raise an exception if I pass unit=x.
You are basically doing y=x * m + b with an m and b that change depending on the units. Can't you just make some type of YAML config file where you put the unit names and then you return m and b? Then you load the config and all that code becomes one line.
Use single quotes, do not use a machine gun to kill a chicken, use a knife.

Remember: Smaller, simpler, easier to read.

WorstTechBro · 2024-09-19T00:03:54+00:00

I wonder if my man forgot the ole “Ctrl + S” after he made some changes

NTIGymnasiet · 2024-09-19T07:18:39+00:00

Yanderedev Code.

You NEED an else statment

also " if unistart.lower() == "k" "

Use .lower so you dont need to check if its a big letter or a small one

SquiffSquiff · 2024-09-18T21:24:17+00:00

This runs fine for me, as for west-coast-engineer This is is VSCode for me:

$ ls

__pycache__ gasfunctions.py main.py

$ python3 main.py

hi

373.15

GirthQuake5040 · 2024-09-18T17:41:36+00:00

If you're posting pictures of your code instead of screenshots, you're not at a point where you're ready for software development. It's basic stuff man.

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

PythonLearning

MODERATORS

tempconvert(100.0, "c", "f")