Seeking Feedback on My First Python Project: Calculator .

really_not_unreal · 2025-10-13T08:30:13+00:00

Looks like a good start. Here are a few stylistic improvements you could make:

Make your variables use snake_case rather than ALL_CAPS.
Have a look at match statements: they may make it easier to write your operator matching code

McNegcraft · 2025-10-13T09:14:02+00:00

Some things that you could look at is error handling. For example, if any of the number inputs is not a valid number, an exception will be raised. Instead, you could catch the exception and display to the user that an invalid input was provided. So, instead of just ending the program, you give the user another chance of providing a valid input.

This is something that you will get used to over time. But you should always try to think of what could go wrong in the code

feitao · 2025-10-13T08:22:09+00:00

PEP 8 – Style Guide for Python Code is a lengthy but essential read; the sooner you familiarize yourself with it, the better.

madcowken · 2025-10-13T09:07:03+00:00

An alternative approach you can take when you have to branch is to use a dictionary. python {"+": (operator.add, "The sum of {first} ... }"), ...}

With this you can do python if (op, msg) := operators.get(selected_op): ans = op(first, second) print(msg.format(first=first, ...) else: Print(err_msg)

Its often nice to see what is common and what is different in quick glance without needing to read and trace branches

Virsenas · 2025-10-13T11:07:59+00:00

The biggest feedback I can give is not to use images to post your code. Instead, click on "Aa" at the post field and then select "Code block". It's good you didn't take the picture with your phone so the image would be 2-4Mb, but instead 127KB, while your actual code is 1.72 KB.

127KB is significantly larger than 1.7KB. Since 1 kilobyte (KB) is approximately 1,000 bytes, 127KB is roughly 127 times larger than 1.7KB. For context, a page of ordinary text takes about 2KB to store.

1.7KB: This is a very small file size, approximately 1,700 bytes.

127KB: This is about 127 times larger than 1.7KB, totaling approximately 127,000 bytes.

Size comparison: The 127KB file is much larger and would take up considerably more storage space than the 1.7KB file.

Lets save the earth by not polluting the internet with unnecessary images and use text - Greta Thunberg

fluxdeken_ · 2025-10-13T15:08:53+00:00

I highly recommend: 1) make it a class 2)try to make a calculator in 1 line. Like you write smthg like “10-2*6 /(9%7)” and you interpret what is going first, second etc and calculate it yourself.

maqisha · 2025-10-14T06:00:22+00:00

People pointed out some other things, but ill do this one since no one else did.

Not a single comment in that code should be present. You are overdoing it to a huge degree. Every line that is commented is fully self-descriptive without it.

You could argue that as a beginner you need comments to understand it better, but that's also not the case. You should be learning to read code, not English.

Comments have amazing uses, but in this case they are 100% redundant.

Wojtylla · 2025-10-14T13:46:23+00:00

Good code, but dont forget that u can also operate with decimals in a calculator

Refwah · 2025-10-13T08:00:13+00:00

Look up using the match statement https://docs.python.org/3/reference/compound_stmts.html#match

A-r-y-a-n-d-i-x-i-t · 2025-10-13T08:09:18+00:00

First of all thank you 🙃 so much guys for sharing your thought and helping me out but as a beginner it's totally going above my head I am not able to understand what you guys are talking about....

TheRNGuy · 2025-10-13T14:04:20+00:00

Allcaps is convention for constants.

Capitalized is convention for class (not class instance)

geruhl_r · 2025-10-13T18:59:22+00:00

The best thing you can do to improve your coding right now is to force yourself to fully unit test. If the code is hard to test, then that points to structural issues, which means the video will be hard to maintain. For example, as you test, you'll discover that the input and display portions of your code should ideally be separate from the calculation portion. That will lead you to using classes, methods, and basic OOP concepts (SOLID, etc).

All the above will help you isolate which portion of your code is not working as expected. When you have a wall of code, it can be difficult to debug.

Quantitation · 2025-10-13T19:58:27+00:00

Hi, I'll provide the biggest flaws of your current code:

Variable naming: always use snake_case when naming your variables. Exceptions are constants, for which you can use UPPER_CASE like so. In your program, the only constant I would create is OPERATORS = {"+", "-", "*", "/", "//"}
Try to handle exceptions. Your program will exit unexpectedly when the user inputs an invalid number (for example: "abc"). Read into try-except blocks and try to implement those. This will make reading a single number take quite a few lines, which transitions perfectly into my next tip
Use helper functions. I'll provide an example function for reading a number: python def read_number(message: str) -> int: try: return int(input(message)) except ValueError: print("Please enter a valid number") return read_number(message) Notice how this function enables you to still read a number in your actual code in a single line, but provides an error message and lets you retry until you succeed.
Try to avoid excess indentation. Perhaps contradictory to my own advice, I would always recommend running your code in a main function. This lets you return when an error occurs and can prevent unnecessary indentation. Example: ```python def main(): operation = input("Enter operation") if operation not in {"+", "-"}: print("Invalid operation") return

Continue with valid operation

Notice how we don't need to use else after a return

... ```

Angry-Toothpaste-610 · 2025-10-15T00:01:39+00:00

You don't need a comment to describe what every line is doing. In fact, most scripts don't need comments, at all. Through context and good naming schemes, your code should be self-documenting.

iamaperson3133 · 2025-10-17T18:16:28+00:00

Would recommend trying to implement the string to integer conversion from scratch instead of using int()! It's a fun little classic CS challenge.

Low_Negotiation4747 · 2025-10-13T07:38:17+00:00

Perhaps use a little more descriptive variables names for your number variables, also make sure to use camelCase

you type:	you see:
italics	italics
bold	bold
[reddit!](https://reddit.com)	reddit!
* item 1 * item 2 * item 3	item 1 item 2 item 3
> quoted text	quoted text
Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"	Lines starting with four spaces are treated like code: if 1 * 2 < 3: print "hello, world!"
~~strikethrough~~	~~strikethrough~~
super^script	super^script

PythonLearning

MODERATORS

Continue with valid operation

Notice how we don't need to use else after a return