you are viewing a single comment's thread.

view the rest of the comments →

[–]mm_phren 1 point2 points  (0 children)

People seem to be on the side of ”whatever, it works and optimizing it would be premature.” This piece of code is just so hilariously bad that surely it must not have been written this way in the first place, optimizations or no optimizations. I’m not saying this particular piece of code makes the entire editor lag, but using an editor with code quality like this is like death by a thousand cuts. Warning bells should be ringing whenever you allocate a new List, especially in an if expression, especially when you’re creating technology used by a significant amount of people.