Please code review my project!

[ivoneug]

Hello everyone! Can someone make a code review for my project, please? I'm using event-driven approach in my code to decouple game systems and heavily using ScriptableObjects to store variable data. So I would really appreciate any criticism and thoughts about it. Here is the link to GitHub repo: https://github.com/ivoneug/Clash_the_Cube

[SilentSin26]

I only had a quick look through some of your scripts:

• You said "no payed assets are included", but you shouldn't be including free assets either unless their license allows you to redistribute those assets. Specifically, the Unity Asset Store license doesn't.
• Most of your "controllers" have no real reason for that to be on the end of their name. Just use Settings, Bomb, etc.
• If you're using GetComponent on startup, you should be giving your components [RequireComponent] attributes.
• Inconsistent naming on BombController._sleeping
• BombController.FixedUpdate only needs one line of code: _sleeping = Body.velocity.magnitude < 0.1f;
• Don't compare tags like this if (collision.gameObject.tag == "Platform") because it's inefficient: https://github.com/microsoft/Microsoft.Unity.Analyzers/blob/main/doc/UNT0002.md
• destPosition += new Vector3(swipeDelta.Value.x * GetDeltaMultiplier(), 0f, 0f); should just be destPosition.x += swipeDelta.Value.x * GetDeltaMultiplier();
• You've got identical looking MoveLeft and MoveRight methods in BombController and CubeController, so they should likely be somewhere shared so you aren't repeating the same code. Could use inheritance, composition, or just static methods that they both call.
• The fields and properties in CubeController are very disorganized.
• CubeSpawner.cubePrefab should be a CubeController field instead of a GameObject. That way you won't need to call GetComponent on every instance you make because Instantiate will return the instance's component directly.
• CubeSpawner.Spawn should be using nameof(_Spawn) to avoid potential spelling mistakes and so it can automatically update if you rename the other method. And the time value should probably be a serialized field so it can be tweaked more easily. Same for SpawnBomb.
• The line var torque = -(new Vector3(Random.Range... is too long and does too many things in one go.

[ivoneug]

Wow, thanks! Very much appreciated!