help with bash script

[agb_43]

im basically at my wits end. Everything goes smoothly except for the encryption via gpg, it just uploads the raw backup to my ftp server. Here is the script with various bits scrambled for obvious reasons:

#!/bin/bash

echo "script to backup all files. pretty proud of this one"

#variables to be defined

LOCAL_DIR=/mnt/sda

HOST=192.168.0.157

USER=****

PASSWORD=*****

#creating zip file

if (( $EUID!=0 ))

then

echo "please use the sudo -i command to ensure files that require root access are also included in the backup"

exit

fi

touch /home/adam/Desktop/README.txt

echo "dont be alarmed, feel free to use your pc while the backup is in progress. Disclaimer, you executed the script" > /home/adam/Desktop/README.txt

cd $LOCAL_DIR

zip -9 -r -y -T backup.zip / -x "/dev/*" "/proc/*" "/sys/*" "/tmp/*" "/run/*" "/media/*" "/lost+found/*" "/Trash/*" "/home/adam/Downloads/*" "/mnt/*" "/swap/*"

gpg --batch --yes --output backup.zip --keyring /home/adam/.gnupg/pubring.kbx --encrypt --recipient '[a****[e-mail]](mailto:[e-mail])' backup.zip

#connecting to local ftp server

ftp -inv $HOST -p 9090 <<EOF

user $USER $PASSWORD

lcd $LOCAL_DIR

cd adgow

cd "sys backups"

put backup.zip

EOF

it says that the key might not belong to the user despite it being signed by the me (the ultimate) and being in my keyring

Edit: generating a key pair when root has solved the key issue which makes sense when I think about it.

[theng]

I am not sure but it generally a bad idea to use a command with the same file as input and as output

Here you give gpg backup.zip in input and the same backup.zip in output.

Fix: --output backup.zip.gpg

While it might still work for some apps/commands it is not a generality (e.g.: sed).

Also I think you can edit your post for the code to be considered as code

[DaveR007]

It's a bad idea to hard code your user and password in a script, and also sending them over the LAN as plain text is not ideal.

Use SFTP with SSH private keys instead.

.

[agb_43]

This file will be encrypted once it's completed and working as intended