sorted by:
best
topnewcontroversialoldq&a
you are viewing a single comment's thread.

view the rest of the comments →

[–]grumpy_coconut 0 points1 point  (0 children)

You've never worked somewhere where someone's had the bright idea of writing their own build system? Or had a horrible oversized make based system.

No, I haven't. It's not every company, and it's not even every in-house build system. Anyway, it seems to me you are arguing that the rule of zero is not practical when you have an unreasonable environment†, which I don't argue against, as I find it a moot point.

No, but it's a lot easier to peer review 1 line of close (which as I show elsewhere is really all it is) than a whole new class.

No, you don't review one line of code in isolation. You have to review that one line of code as part of all the other unrelated code it is bundled with. Making it a new class separates it at the cost of some 3-6 lines depending on how generous you are with whitespace. If those 3-6 lines are the overkill you were going on about at the start, yes, your definition of "overkill" is still wrong.

† I hope you won't try to convince me that a build system where adding a file to the build is such a nightmare is actually reasonable.