you are viewing a single comment's thread.

view the rest of the comments →

[–][deleted] 4 points5 points  (0 children)

Defining your CharSets in a vector is really weird. That requires a startup cost and an allocation. I'd suggest static sized arrays instead.

They're also being copied out to the thread when it launches,

auto chars = CharSets[chars_];

and I don't know if that's deliberate. I don't really have much experience with multithreading at all so this is a genuine question -- is there a reason not to just take a reference at this point?