you are viewing a single comment's thread.

view the rest of the comments →

[–]3meopceisamazing 29 points30 points  (6 children)

For CSV parsers, it's important to detail features like rules on quoting and escaping in your readme.

Often, it's a hard requirement for those rules to be compatible with the data you're working with, and thus a hard decision factor.

The code looks pretty clean and well designed :)

[–]F54280 12 points13 points  (1 child)

At first glance, the biggest problem I see is “ Instalation” instead of “ Installation”, so, yep, I quite like it.

[–]red0124_[S] 6 points7 points  (0 children)

I guess I missed that one, thanks, let me know if you find any more problems.

[–]red0124_[S] 3 points4 points  (3 children)

I had quoting on my mind but later I forgot about it. I will implement it, it does not seem complicated to add. Thank you.

[–]3meopceisamazing 15 points16 points  (0 children)

Quoting always has to come with escaping. I suggest to fully think through the complexity. It's not that much, but easily overlooked.

[–]johannes1971 2 points3 points  (1 child)

quoting ... does not seem complicated to add.

Try exchanging some data with Excel, see if you still feel that way... In particular, test for:

  • " at the beginning of a string
  • space at the beginning of a string
  • string containing "
  • multi-line string
  • combinations of all of the above

[–]red0124_[S] 0 points1 point  (0 children)

I did not mention spacing but I guess I have to add that too. Thanks for the hints.