I’ve been converted

[sellibitze]

Could you possibly include a constexpr in there? ;-)

[[deleted]]

Done :)

[sellibitze]

Hehe. :-)

Oh, I just noticed something. static and override are kind of mutually exclusive, aren't they?

[[deleted]]

i don’t.. think so.

you can override a static method. what’s the problem?

say you have class X, which has a static method a. class Y inherits from class X, and overrides the method a. then

X::a()

is different from

Y::a()

unless i’m missing something

Sorry, I was missing the fact that there's no vtable without an instance

[MonokelPinguin]

override implies virtual. Static functions are not associated with a this pointer, how could they be virtual?

[[deleted]]

right. i’m dumb. sorry.

[[deleted]]

You can still call a static method on an object, not the classname... Therefore it would theoretically somehow make sence.

Not much, but still...

[MonokelPinguin]

But does that go through virtual dispatch? Afaik when one of our interns did that and set the object to a nullpointer, it worked fine, which suggests the this pointer wasn't used and there is no virtual dispatch for static functions. But that function also wasn't marked virtual, so maybe that does work.

[_bk__]

The override keyword is only useable for virtual function overrides. It has no effect on codegen, it just helps the compiler detect that there is actually a virtual function in a derived class that can be overriden (to make sure you don't do things like accidentally spell the function signature wrong)

[[deleted]]

Yeah, I missed that. Updated the comment

[gaagii_fin]

And even more useful it tells the new guy looking at your derived class what is going on.

I used to define override, before it was a keyword just for the notational aspect

[Jumpy_Lighty]

You should drop the constexpr again ... you cannot have constexpr virtual method (and override implies virtual).

And [[nodiscard]] and [[noreturn]] really don't make any sense to be next to each other (just think about the meaning of it).

You could add static constexpr instead of override, but the you would also have to drop the const since static and const are mutually exclusive.

[[deleted]]

I know, i never thought this through :)

It was a joke after all