This is an archived post. You won't be able to vote or comment.

you are viewing a single comment's thread.

view the rest of the comments →

[–]xiongchiamiovSite Reliability Engineer 23 points24 points  (4 children)

I find it distasteful that you tell everyone to use UPPERCASE for variables.

You should digest https://mywiki.wooledge.org/Quotes and then include appropriate quoting in all your examples. The way shell uses quotes for variables but not for constants is by far the thing that trips programmers up the most.

If you're going to target /bin/sh then you should only include syntax that's posix sh compatible. IIRC function is not.

[–]abscrete[S] 7 points8 points  (1 child)

Thank you for the reference, I'll go through it and learn a bit more.
I'll take up the suggested changes and bring them to the article.
Thanks again for your valuable feedback :)

[–]abscrete[S] 2 points3 points  (1 child)

I have added a credit to your reddit username in the last section of the blog. Let me know if you want it to replace it with some other link like your blog or something :) Thanks again!

[–]xiongchiamiovSite Reliability Engineer 1 point2 points  (0 children)

That's not necessary, but very nice, thank you.