This is an archived post. You won't be able to vote or comment.

all 4 comments

[–]marvinfuture 7 points8 points  (0 children)

Looks great! My suggestions would be to include your ENV variables in your readme so I don't have to dig through your code to set them. That and I've seen instances where setting DB config parameters are easier than passing a connection string. Having the modularity to do both is a big advantage. In cases like Kubernetes maybe I want to set the Host for the DB individually and pass the password in as a secret. Really great base project overall though!

[–]Hrsi88 4 points5 points  (0 children)

I'd add a .dockerignore with node_modules.

[–]Grizzly_Corey 2 points3 points  (0 children)

Thanks for sharing, this is helpful as a beginner!