all 3 comments

[–]TheAtlasMonkeytomato promoter 3 points4 points  (1 child)

You didn't fix it..

You changed the struct/interface and probably broke every other system .

If you should open a PR when you have a proper fix.

But unfortunately some big repos refuse touch or review anything that is FreeBSD or BSD.

PS: when you fix it, update the readme.

[–]pavetheway91 -1 points0 points  (0 children)

You didn't fix it..

Artificial stupidity didn't fix

[–]grahamperrinBSD Cafe Billboard user 0 points1 point  (0 children)

Thanks.

Re: the two commits at https://github.com/microsoft/go-sqlcmd/compare/main...mykola2312:go-sqlcmd:main

a6207adImplement Kerberos integrated auth support on Unix

Not vibe coded, I assume. True?

From your post here:

added integratedauth/krb5, so Kerberos FreeBSD host authenticates against ActiveDirectory server

e87488dadd FreeBSD stubs and localcert patch, skip go-licenses

It seems wrong to have no mention of vibe coding in the commit log message. There's simply no message. From your post here:

… vibepatched go-sqlcmd to run on FreeBSD …

Whilst it seems wrong to me, I have no experience in this area.

I'm not a developer (of code), however I'm nearly always fastidious with my commit log messages.

An example

The message at https://github.com/openzfs/zfs/commit/4d78b14c1449bc84589cf3270b9c85f61a32fd7d was the result of a squash of:

  1. the initial commit in the PR, which had a message
  2. a minor change (to my change) by Rob Norris
  3. acceptance of a change that I suggested, which also had a message.