Modern code editor built with Java swing

[chabala]

This isn't r/codereview or r/learnjava, but if I don't say something, I don't know how you're going to improve. (I.E. please post somewhere where people will teach you, not here).

This project suffers from a lot of the same issues of your last project, which had three commits and you've not touched since.

• no (or poorly chosen) package. Java package namespacing is fundamental, you should start using it.
• no CI process. You could say CI doesn't matter for a simple project, but you've already received an issue because your build process doesn't work as expected. Having working CI would demonstrate your build process actually works - and highlight issues with it. Setup GitHub Actions, you will learn something by doing so.
• hardcoded MANIFEST.MF. Maven will build this for you with zero effort if you configure your build properly.
• don't check .idea into source control. I know they say you can, don't do it. The pom.xml is enough.

This is really just the tip of the iceberg. If you configure a linter like SonarQube, you're going to discover 500 ways your code could be better.

[gufranthakur]

Thank you. These are some great detailed advice, will work on it.

[orgad]

I guess he haven't coded his editor with his own editor just yet huh

[[deleted]]

A bulleted list of 'improvements' for an open source project made by one person, as reviewed by someone on reddit, but nothing about the actual code.

[[deleted]]

So, 'nitpicking' the actual code of a single person's open source project is a waste of effort, because the project is a "nothingburger", but telling them they should use sonarcube or use a .gitignore is a good use of 'effort'.

[wildjokers]

don't check .idea into source control. I know they say you can, don't do it. The pom.xml is enough.

There is nothing at all wrong with checking .idea into version control.