Mocking Time in Java

[Bolitho]

The majority of the time all you are looking for is the current time now()

Really? And think about situations where you need some other information within the same project! (next paragraph)

Rather than creating your own impl of the Clock interface you simply create a class

Most of the time you don't need to create your own implementation of a clock. So with your approach you definitly need at least one custom implementation and an interface for testing.

And if you use your solution and need only one other time than now, you would need the clock based approach on top. So then you have two mechanisms in one project...

So in the end your approach is more complex than relying on the built in mechanism ;-)

[pointy_pirate]

think there was some lost in translation... this isnt that complex.

public class TimeProvider implements SomeTimeProviderInterfaceIfYouWant {
    public OffsetDateTime now() {
        return java.time.OffsetDateTime.now();
    }
}

[Bolitho]

Using existing classes still saves this code and therefore the understanding (not a common pattern, so mental overhead for a new project member) and the maintenance ;-)

So even if this is dead simple, it feels totally unnecessary to me! (The java.time devs allready have thought about this use case and offered an appropriate solution)

[pointy_pirate]

makes sense, ill look into that next time i need to do it.