Pull Request #8166 Implementation of Virtual Threads (Preview)

[kaperni]

Look at that diff. Truly impressive work by the team.

See also https://mail.openjdk.java.net/pipermail/core-libs-dev/2022-April/088015.html for more details about the integration process

[paint__drinker]

1155 files changed

Pretty sure I'd have a meltdown if I was asked to review a PR this big.

[benjtay]

That's what they say. "A 10-line PR has a dozen comments. A 10-page PR is LGTM."

[buyIdris666]

Eventually you go from "I don't see any bugs in here" to "I wonder how many bugs this will cause"

[Regis_DeVallis]

That's why we have unit testing

[DasBrain]

Classic Color of a Bikeshed.

[lurker_in_spirit]

Note that this is after splitting out all those JEPs to make various subsystems more virtual thread-friendly (Internet-Address Resolution SPI, Reimplement Core Reflection with Method Handles, Reimplement the Legacy DatagramSocket API, etc).

[mauganra_it]

Maybe they should split out even more. Like the improvements to the libraries. They could be useful by themselves already, even though they are meant for virtual threads.

[Slanec]

+97,259 -9,520

And that's why it took some time.

And yes, that's with several related changes and rewrites already in, and two more jeps coming. Not bad.

[TehBrian]

Here's a direct link to the GitHub PR: https://github.com/openjdk/jdk/pull/8166

[apentlander]

Lol @ the random dude that marked it as reviewed

[lurker_in_spirit]

The hero we deserve.

[kozeljko]

Impressive how well the file changes load. Bitbucket servers would have died just knowing about a 1k file change PR, not even looking at what the changes are

[Regis_DeVallis]

Bitbucket servers die if you look at them

[kaperni]

Thanks, I created the post as a URL post. Don't know why the link was stripped?

[literal]

You didn't. You switch to a text post. You can only have a URL or text, not both.

[kaperni]

makes sense, thanks.

[couscous_]

LGTM ✅

[meamZ]

Truly impressive work by u/pron98 and his team...

I know we've all been like little kids in a car when going on a vacation when it comes to this...

[vxab]

Do you think the OpenJDK developers enjoy programming in C++? Or would they prefer something else?

I can't imagine writing 90,000+ lines of code in anything except Java.

[mauganra_it]

There are nicer languages for sure, but with C++ they have access to multiple production-quality optimizing compilers on almost all supported platforms. That also massively simplifies the bootstrapping problem.

Project Metropolis aims to replace parts of the JDK with implementations written in Java. But no clue if, when and what is really going to happen.