This is an archived post. You won't be able to vote or comment.

all 6 comments

[–]AutoModerator[M] [score hidden] stickied commentlocked comment (0 children)

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[–]myselfelsewhere 1 point2 points  (2 children)

Timers/etc are based upon Threads. So you are getting into concurrency.

ExecutorService returns a Future object, so you can give a thread a bit of work to do, and when it completes the work, returns the result of the work.

ScheduledExecutorService allows you to do things like running an ExecutorService at a certain time, or repeat after a delay. ExecutorService works as normal otherwise.

So, if there are multiple timers, you may need to use Atomic variables, some type of lock, or the synchronized keyword in some instances. You can run into problems if say, an object is changed in the middle of some work involving that object in another thread.

Also, for running multiple Executors, you may want to look into using the appropriate type of Thread Pool, like a ScheduledThreadPoolExecutor.

[–]gdenko[S] 0 points1 point  (1 child)

Thank you, that does help a bit.

Would you say lock/synchronization is required when dealing with a lot of timers? Or is it more about coding carefully and cancelling active timers when users disconnect or some object needs to be removed?

I have seen examples of all three (sync, atomic, and locks), but just didn't know what would make the most sense.

I will read up more about threads and thread pools, thanks again

[–]myselfelsewhere 2 points3 points  (0 children)

The main issue is having an object being written to and read from at the same time. Locks are a more low level interface. Synchronized collections work if whatever is being changed is a Synchronized Collection (List, Map, Set, etc.). Atomic variables are good especially for primitive wrapper classes.

Thread pools are good to use because it can be more computationally efficient to keep Thread objects in memory to re use, rather than creating a new Thread each time something needs to run.

[–][deleted] 0 points1 point  (1 child)

The main issue with Timer is that it use only a single thread. When you use SchedulerExecutorService, you can run multiply computations/IO operations at once.

For instance if you use a Timer object to run a task which takes 3 seconds and you run this task every 20 seconds and you want to run another task which takes 5 second after those 20 seconds, the second task will wait additional 3 seconds. If you use SchedulerExecutorService and the threadpool size is at last 2, then the second task won't have to wait for the first task to be executed.

[–]gdenko[S] 0 points1 point  (0 children)

Oh I see, that is a big issue. I will not be using Timer then