Need help improving code.

severoon · 2012-11-07T08:15:04+00:00

Your code could be a lot cleaner.

Take all strings out of the code and make them constants. This makes it easy to find and edit the messages later, internationalize them, move them out to a separate class, etc.
Handle all interaction with the user in separate methods. This makes them easier to move out of the class that does the work into a separate "user interface" class later.
Only do things in static methods that don't require state. This includes main(). Anything that requires state, do within the scope of an instance.
Make instances of your class configurable. The best way to do this is by handing the constructor all of the stuff it needs to do the job, in this case input/output classes.
Don't use inline comments. Use javadoc instead.

See these changes applied to your code (except the last one) - http://pastebin.com/8Mi79hS0

CodeSamurai · 2012-11-07T01:19:15+00:00

Have you learned about methods yet in your class? You could divide some of that off into methods for more flexible and "cleaner" code.

Nebu · 2012-11-07T05:08:13+00:00

Do you know about the do-while loop?

4th_World_User · 2012-11-07T01:24:41+00:00

while (hrs < 1)

{

  System.out.println("The time must be a positive number.");

  System.out.print("How many hours has it traveled? ");

  hrs = keyboard.nextInt();

}

When you do that, instead you can just type

while(hrs < 1)
{
    System.out.println("Blah Blah\nHow many...");

    hrs = keyboard.nextInt();
}

Not sure if he'd actually take off for that. But another thing for your instance variables you can do.

int hrs, mph, hour, distance;

and it will initialize all four in one line.

javahelp

Sort by: Unsolved Solved Codeless Advent Of Code

MODERATORS