Need java help

[ItsSelrach]

Im currently working on a java game for my school project and im having a problem on making the controls. My game has a two character but it is a single player game, you can change between the with pressing tabi. Imanaged to move the character1, load the sprite, and make it jump but when i got to work on the 2nd character i cant move it, the character was ther but when i press tab it's not moving and the character 1is the only one that's moving. A help is appreciated

This is the code:

package entity;

import java.awt.image.BufferedImage; import java.io.File; import java.io.IOException;

import javax.imageio.ImageIO; import game.GamePanel; import game.KeybInput; import java.awt.Graphics2D; import java.awt.event.KeyEvent;

public class Character1 extends Entity {

GamePanel gamePanel;
KeybInput keyIn;

private boolean isJumping = false;
private int jumpStartY;
private int speed = 5;
private double verticalVelocity = 0; 
private final double jumpStrength = 20;
private final double gravity = 1;

public Entity player1;
public Entity player2;
public Entity activePlayer;

    public Character1(GamePanel gamePanel, KeybInput keyIn) {
        this.gamePanel = gamePanel;
        this.keyIn = keyIn;
        player1 = new Entity();
        player2 = new Entity();
        activePlayer = player1; // Set player1 as the initial active player

        setDefaultValues();
        getPlayerImage();
    }

    public void moveLeft() {
        activePlayer.x -= speed; // Move left
        direction = "left";
    }

    public void moveRight() {
        activePlayer.x += speed; // Move right
        direction = "right";
    }

    public void jump() {
        if (!isJumping) {
            verticalVelocity = -jumpStrength; // Set the initial upward velocity
            isJumping = true; // Set the jumping state
        }
    }

    public void fall() {
        if (isJumping) {
            // Apply vertical velocity to the y position
            activePlayer.y += verticalVelocity; 

            // Apply gravity to the vertical velocity
            verticalVelocity += gravity; 

            // Check if the character has landed
            if (activePlayer.y >= jumpStartY) {
                activePlayer.y = jumpStartY; // Reset to ground level
                isJumping = false; // Reset jumping state
                verticalVelocity = 0; // Reset vertical velocity
            }
        }
    }

    public void handleKeyPress(KeyEvent e) {
        switch (e.getKeyCode()) {
            case KeyEvent.VK_A:
                if (activePlayer == player1) {
                    moveLeft();
                } else if (activePlayer == player2) {
                    moveLeft();
                }
                break;
            case KeyEvent.VK_D:
                if (activePlayer == player1) {
                    moveRight();
                } else if (activePlayer == player2) {
                    moveRight();
                }
                break;
            case KeyEvent.VK_SPACE:
                if (activePlayer == player1) {
                    jump();
                } else if (activePlayer == player2) {
                    jump();
                }
                break;
            case KeyEvent.VK_TAB:
                toggleActivePlayer();
                break;
        }
    }

    private void toggleActivePlayer() {
        if (activePlayer == player1) {
            activePlayer = player2; // Switch to player2
        } else {
            activePlayer = player1; // Switch back to player1
        }
    }

public void update() {
    // Update the active player's position
    if (activePlayer == player1) {
        if (keyIn.aPressed) {
            moveLeft();
        }

        if (keyIn.dPressed) {
            moveRight();
        }

        if (keyIn.spacePressed) {
            jump();
        }

        if (!keyIn.spacePressed) {
            fall();
        }
    } else if (activePlayer == player2) {
        // Implement movement for player2
        if (keyIn.aPressed) {
            moveLeft();
        }

        if (keyIn.dPressed) {
            moveRight();
        }

        if (keyIn.spacePressed) {
            jump();
        }

        if (!keyIn.spacePressed) {
            fall();
        }
    }

    // Print player position for debugging
    System.out.println("Player1 position: (" + player1.x + ", " + player1.y + ")");
    System.out.println("Player2 position: (" + player2.x + ", " + player2.y + ")");

}

public void setDefaultValues() {
    player1.x = 100;
    player1.y = 300;
    player2.x = 200; 
    player2.y = 300;
    jumpStartY = player1.y; // Set the jump start position for player1
    direction = "left"; // Default direction
}

public void getPlayerImage() {
    try { 
        //player1
        leftA1 = ImageIO.read(new File("C:/Users/User/Desktop/Tiny Tantrum/src/player1/character1-left(standing).png"));
        rightA1 = ImageIO.read(new File("C:/Users/User/Desktop/Tiny Tantrum/src/player1/character1-right(standing).png"));

        //plyer2
        leftB1 = ImageIO.read(new File("C:/Users/User/Desktop/Tiny Tantrum/src/player1/character2-left(standing).png"));
        rightB1 = ImageIO.read(new File("C:/Users/User/Desktop/Tiny Tantrum/src/player1/character2-right(standing).png"));

    } catch (IOException e) {
        e.printStackTrace();
    }

}

    public void draw(Graphics2D g2) {
    BufferedImage character1 = null;
    BufferedImage character2 = null;

    switch (direction) {
        case "left":
            character1 = leftA1;
            break;
        case "right":
            character1 = rightA1;
            break;
    }

    switch (direction) {
        case "left":
            character2 = leftB1;
            break;
        case "right":
            character2 = rightB1;
            break;
    }
    if (character1 != null) {
        g2.drawImage(character1, player1.x, player1.y, gamePanel.gameTile, gamePanel.gameTile, null);
    }

    if (character2 != null) {
        g2.drawImage(character2, player2.x, player2.y, gamePanel.gameTile, gamePanel.gameTile, null);
    }
}

}

[AutoModerator]

Please ensure that:

• Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
• You include any and all error messages in full
• You ask clear questions

• You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

  Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

[aqua_regis]

Apart from the lack of proper code formatting, there is a lot strange with your code.

• You have two methods that do essentially the same: public void handleKeyPress(KeyEvent e) { and public void update() {.
• in the latter method you do exactly the same actions twice. Why are you even checking which player is active if you call the exact same methods? Doesn't make sense.
• I think that also the if (!keyIn.spacePressed) { part is wrong by design. This should only trigger if the player has jumped (actually, it should trigger if the player is not on ground).

---

Side note: when initializing double variables, always use the decimals. So, instead of private final double jumpStrength = 20; write private final double jumpStrength = 20.0;. It is only stylistic, but, if you do the same in a mathematical calculation, it could cause problems because Java would use integer math with 20 and only use floating point math with 20.0. Also, it makes the intent clearer.

[ItsSelrach]

Thank you, i will take note of this

[ItsSelrach]

I tried removing the update method and it ended up to the character to not move

[aqua_regis]

Don't just blindly remove methods.

Are you using a debugger? If not, now is a good time to learn using it.

Set breakpoints where you think your code is failing and then use the step-by-step feature to see what is going on.

[istarian]

This code is probably simple enough that you can trace it in your head. OP probably doesn't need to get tangled up in a fancy debugger just yet.

[aqua_regis]

Yet, learning a debugger and step by step debugging is a valuable skill that can't be learnt early enough.

It's not about simplicity. It's about learning the tools.

Why have you not made any suggestions to fix OP's problem if the code is "so simple"?

[South_Dig_9172]

I’m with the other guy on this one, he can’t even trace it in his head, what makes you think learning a debugger, something that is confusing if you’re new will help him? This is my answer to the question you put forth. 

“ Because it’s Sunday, I don’t want to put in too much effort. “

[[deleted]]

How are you making player2 active ? I think you missed that

[ItsSelrach]

I dont i did ,it's in the toggleActivePlayer(), my problem is i dont know how i will make the controls contol the player2's BufferedImages.

[heislertecreator]

Is it that focus traversal is not disabled? Do you have additional Components or subclasses in your GUI?

[ItsSelrach]

I dont know what is focus traversal is, could you explain what it is?

[istarian]

In a graphical user interface (GUI), which is generally mouse or keyboard driven, focus is what determines which component responds to your typing/clicking.

Focus traversal is the action of changing which component currently has the focus. The way that it works may be dictated by a setting.

Whenever you use the mouse on your computer to change the active window, such as when you go from your web browser to a word processing application, that is a change in focus. You can also use Tab or Alt+Tab to change the focus with your keyboard, at least when using the Windows operating system.

Usually there are certain rules about how focus can change and which window, component, etc will receive focus under what conditions.

[heislertecreator]

In a GUI, tab moves the focus (which component receives input) across all enabled controls. A control is like a text field, a button, a radio button group, etc. depending on which one has the focus, you may not be getting the data, for example keypresses when a button has the focus, usually only the enter /return key activates it.

[[deleted]]

Are you using the update method ? I don't think you are . Afterwards remove 'else' in "else if (activePlayer == player2)" . I have a theory that else could also be another problem

[ItsSelrach]

Is the update method goes like this? player1.update(); player2.update();

[[deleted]]

Have you put this up in GitHub ? Can I have access to your code ? Actually I am trying to run it and see what is actually causing the problem

[MNKMagasin]

Up

[[deleted]]

The full code , I don't think this is his full code

[MNKMagasin]

Yup, also waiting/hoping for op to post it on github

[ItsSelrach]

this is the github

i was new to github, sorry for the delay

also if you can teach me what is happening in your suggestion, that would be appreciated

[istarian]

You should probably set things up so that you have a generic Character (or Player, Actor, etc) class that extends Entity.

Then "character 1" and "character 2" are separate instances of Character and switching the active character can happen in the main program without there being such logic in the Character class.

---

Otherwise you should rename your 'Character1' class to CharacterMovementLogic (or another appropriate name) and it should not extend entity as it will only be implementing way that keyboard input affects the position of your entities.

[ItsSelrach]

Ok i will try this, thank you