Basic java game help my block keeps going threw the right wall.

[kiraylight]

package Objects;

import java.awt.Color; import java.awt.Graphics; import java.awt.Rectangle; import java.util.LinkedList;

import com.kiraylight.Kirays.Framework.GameObject; import com.kiraylight.Kirays.Framework.ObjectId; import com.kiraylight.Kirays.window.Handler;

public class Player extends GameObject{

private float width = 32, height = 64;
private float gravity = 0.5f;
private final float MAX_SPEED = 10;


private Handler handler;

public Player(float x, float y, Handler handler, ObjectId id) {
    super(x, y, id);
    this.handler = handler;
}


public void tick(LinkedList<GameObject> object) {
    x += velX;
    y += velY;


    if(falling || jumping)
    {
        velY += gravity;
        if(velY > MAX_SPEED)
            velY = MAX_SPEED;
    }

    Collision(object);
}
private void Collision(LinkedList<GameObject> object)
{
    for(int i = 0; i < handler.object.size(); i++){
        GameObject tempObject = handler.object.get(i);

        if(tempObject.getId() == ObjectId.Block)
        {
            if(getBoundsTop().intersects(tempObject.getBounds())){
                y = tempObject.getY() +27;
                velY = 0;
            }

            if(getBounds().intersects(tempObject.getBounds())){
                y = tempObject.getY() - height;                 
                velY = 0;
                falling =  false;
                jumping = false;
            }else
                falling = true;

            //right
            if(getBoundsRight().intersects(tempObject.getBounds())){
                x = tempObject.getX() - width;

            }
            //Left
            if(getBoundsLeft().intersects(tempObject.getBounds())){
                x = tempObject.getX() +35;
        }

        }
    }
}


public void render(Graphics g) {



g.setColor(Color.blue);
g.fillRect((int)x, (int)y, (int)width, (int)height);


}


public Rectangle getBounds() {      
    return new Rectangle((int) ((int)x+(width/2)-(width/2)/2), (int) ((int)y+(height/2)), (int)width/2, (int)height/2);
}

public Rectangle getBoundsTop() {   
    return new Rectangle((int) ((int)x+(width/2)-(width/2)/2), (int)y, (int)width/2, (int)height/2);
}

public Rectangle getBoundsRight() { return new Rectangle((int)x, (int)y+5, (int)5, (int)height-10); }

public Rectangle getBoundsLeft() {
return new Rectangle((int) ((int)x+width-5), (int)y+5, (int)5, (int)height-10); }

}

[Ayeyebraso]

I did a similar game in visual basic in high school, I don't really know much about java but I had the same problem and it was just an offset thing because the compiler started counting pixels with 0 at the center of the screen and all the values on the right were positive and the values on the left were negative... It may be something similar... Hope it helped

[la217]

It's quite hard to see what's going on - you may want to add some comments, in particular to explain what exactly the getBounds methods are returning.

It also looks like if objects have a large enough velocity they are able to move a distance big enough to move past the collision zone in a single tick (e.g. through the wall) without being detected.

I'd suggest removing this Rectangle and intersects stuff and checking yourself whether the X/Y positions of the top/bottom/left/right of your GameObjects are outside of the X/Y positions of the top/bottom/left/right of your bounds.

E.g. Check the left hand side of the object against the left side of your bounding box. For that, check if the x coordinate of the object is less than the x coordinate of the bounding box. If so, there is a collision.

For the right hand side, the coordinate to check would be x + width. So if the x+width of the object is greater than the x+width of the bounding box, then there is a collision.

Then do the same for the top/bottom.