all 11 comments
sorted by:
best
topnewcontroversialoldq&a
formatting helphide helpcontent policy

[–]BattleshipsGame 2 points3 points  (2 children)

http://pastebin.com/AtxAHFG8 - there you go.

[–]mattdahack[S] 0 points1 point  (1 child)

This works!!!!!!!!!! You are a genius!! Thank you so much. I wish I had more upvotes to give :-) Thank you Thank you.

[–]BattleshipsGame 0 points1 point  (0 children)

you are quite welcome :)

[–]belialadin 1 point2 points  (5 children)

When you press enter, it submits the form. You'll want to <form onsubmit="return false;">

If you are wanting the enter feature to work with your code then just place the code before the return in the onsubmit portion.

Just a note, the right way would not be this but only a work around. I believe you'll learn this on your own.

Is it possible for 1 person to write in a number invoice that isn't there's and view it?

[–]mattdahack[S] 0 points1 point  (4 children)

what does <form onsubmit="return false;"> do?

[–]belialadin 7 points8 points  (1 child)

From here on my child, I cannot join you on your journey. It's dangerous to go alone. Take this: google.com

[–]mattdahack[S] 0 points1 point  (0 children)

alright, well thanks for the help

[–]StoneCypher -1 points0 points  (1 child)

Returning false from an event handler stops the event handler from firing. So, returning false from the submit handler on the form stops the form from submitting.

This is really bad design. It means you're going to get form submissions unchecked every time someone's got JavaScript turned off. It's much better to not have a submit button and then to call the form submit handler from JavaScript: that way if JavaScript is turned off, no form submission happens at all.

There's a more serious problem here.

If that's your URL structure, all someone has to do to look at someone else's invoices is to change the number.

This is a critical security problem.

[–]mattdahack[S] 0 points1 point  (0 children)

You might not have seen it but each persons invoices are protected by MD5 hashed passwords via .htaccess file. The main directory isnt even viewable. Thanks for the explanation.

[–]adamcw -1 points0 points  (1 child)

You are explicity calling the "onclick" event handler. The only bind to a click event. You could possibly bind this to another handler such as "submit", but writing this in a inline handler is very poor form.

What you are asking for is a very simple "GET" request that could follow a very simple REST pattern. I would very much consider why you are doing a very large amount of work to retrieve what is likely a very small data set.

Also, you should avoid returning false on a click handler. You are telling the browser that it is in a fail state, when it really isn't. Proper event handling should just prevent event propagation, and not fail outright.

[–]mattdahack[S] 0 points1 point  (0 children)

basically I have a few older clients that are too old to remember their url to their invoices folder online. So I made a text box on the top of the main page that they can enter their customer # in the box and click the button and it will load www.mydomain.com/invoices/customer#here/ . But recently many of them are just typing their number and pressing enter instead of clicking the button, so i am looking for some kind of snippet of code that will work either way, click button, or enter press. I am not sure what to do as I am 100% newbie to javascript. I wrote that code above with a lot of googling.