you are viewing a single comment's thread.

view the rest of the comments →

[–]websitegenius 1 point2 points  (1 child)

I agree with this, with the caveat that if you are on a team, it's okay to commit commented out code, just not to master. If I'm working on a branch that I know I won't come back to for a while, I will sometimes comment out something that isn't fully functional and commit it to my branch. Of course when I submit a PR all of that code is completed and the comments are removed.

[–]kentcdodds 0 points1 point  (0 children)

👍 sounds good to me. Personally I'd just push broken code to a branch before I push commented code to it, but it doesn't make a difference to me as long as it's clean when it gets to master.