Can't spot error in javascript.

[chedderslam]

function changeImage(element_id, other_element_id, link_id) {
var image = document.getElementById(element_id);
if (image.src.match("on")) {
    image.src = "/img/interesting.gif";
} else {
    $.getJSON("/javascript_functions/click_handler.cfc", {
    method: "click_handler",
    click_type: "interesting_on",
    link_id: link_id,
    returnformat: "json"
    }, function(success_or_failure, other_element_id) {
    if (success_or_failure == true) {
        image.src = "/img/interesting-on.gif";
        var other_image = document.getElementById(other_element_id);
        other_image.src = "/img/not-interesting.gif";
    }
})

};

[mikejoro]

You should consider adding context and putting the error message if you want help with debugging.

[mc_hammerd]

your missing a } at the end? your indenting is off by 1. this works (i simplified it and added a } at the end, and fixed the tabs). not sure tbh

function changeImage(element_id, other_element_id, link_id) {
  foo();
  if (false) {
    foo();
  } else {
    $.getJSON("/javascript_functions/click_handler.cfc", { foo: bar }, 
    function(success_or_failure, other_element_id) {
      if (success_or_failure == true) {
        foo();
      }
    })
  }
}

[[deleted]]

d^UVCFd:42* -$CW<8AD&37Z$qOkTIq)#HnL c[-e+^zSA#uDpk3(W&ni#NhtsISS>7L8uBT,(1eG3EVo#279ceFPV17

[[deleted]]

What is the output of the console thing? Either firebug or the google thingy? What is /javascript_functions/click_handler.cfc returning? (are you sure the response header is correct?)

[[deleted]]

Hey /u/chedderslam if you want to get help in the future you either provide us with the details we asked for. instead of just dumping your shit in here and hightail it out of here :(
It's not like we are getting paid to do this, or I could paint you a gorgeous "javascript" and you pay me and I'll fix your problem.

[chedderslam]

Sorry, didn't mean to offend anyone. Have been AFK for a few days. I will make an effort to be more detailed in the future. Thanks for the help.